Skip to content

fix(material/slide-toggle): increase slide toggle ripple touch target #31469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/slide-toggle): increase slide toggle ripple touch target #31469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/material/slide-toggle/_m2-slide-toggle.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@
),
density: (
slide-toggle-state-layer-size: map.get((
0: 40px,
-1: 36px,
-2: 32px,
-3: 28px,
0: 48px,
Copy link
Member

@crisbeto crisbeto Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is the right way to solve the issue, it just makes the ripple larger and ripples are meant to be decorative. The way we handle the touch target in other components is to have a transparent div that is always at least 48x48 and isn't affected by density. See .mat-mdc-radio-touch-target as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by @andrewseguin actually instead of #31178.

I'll take a look at mat-mdc-radio-touch-target.

Another issue with increasing the ripple is it can add a scrollbar when the toggle is at the bottom, breaking quite a few screenshot tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that #31178 is the proper way to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does actually look like a simpler and better solution that either of the others. Started at #31486.

-1: 44px,
-2: 40px,
-3: 36px,
), $density-scale)
),
);
Expand Down
2 changes: 1 addition & 1 deletion src/material/slide-toggle/_m3-slide-toggle.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
slide-toggle-selected-track-outline-color: transparent,
slide-toggle-selected-track-outline-width: 2px,
slide-toggle-selected-with-icon-handle-horizontal-margin: 0 24px,
slide-toggle-state-layer-size: 40px,
slide-toggle-state-layer-size: 48px,
slide-toggle-track-height: 32px,
slide-toggle-track-outline-width: 2px,
slide-toggle-track-shape: map.get($system, corner-full),
Expand Down
Loading