Skip to content

feat(material/button): Add support for showing a progress indicator inside the button#32698

Merged
andrewseguin merged 1 commit intoangular:mainfrom
jermowery:progress-button
Feb 26, 2026
Merged

feat(material/button): Add support for showing a progress indicator inside the button#32698
andrewseguin merged 1 commit intoangular:mainfrom
jermowery:progress-button

Conversation

@jermowery
Copy link
Contributor

@jermowery jermowery commented Jan 25, 2026 •
edited
Loading

Add a new API, testing API, and docs for allowing progress indicators to be projected into a button and have them shown in an accessible manner

Fixes #13667

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/button labels Jan 26, 2026
@jermowery jermowery changed the title Progress button feat(material/button): Add support for showing a progress indicator inside the button Jan 26, 2026
@jermowery jermowery marked this pull request as ready for review January 26, 2026 03:13
@pullapprove pullapprove bot requested review from crisbeto and ok7sai January 26, 2026 03:13
@jermowery
Copy link
Contributor Author

jermowery commented Jan 26, 2026

@andrewseguin as we discussed internally, I have reverted the formatting changes you wanted reverted and added the updated documentation

@jermowery jermowery mentioned this pull request Jan 30, 2026
Closed
@jermowery
Copy link
Contributor Author

jermowery commented Feb 2, 2026

Did a TGP internally https://fusion2.corp.google.com/presubmit/863352307/OCL:863352307:BASE:863352029:1769841365872:d813d7d/targets

@jermowery
Copy link
Contributor Author

jermowery commented Feb 2, 2026

@crisbeto the TGP failures appear to be completely contained to the SVG selector you pointed out, any ideas on how we can avoid including the SVG in the progress spinner without making the selector more specific?

@andrewseguin andrewseguin added dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Feb 23, 2026
@github-actions
Copy link

github-actions bot commented Feb 23, 2026 •
edited
Loading

Deployed dev-app for d148f88 to: https://ng-dev-previews-comp--pr-angular-components-32698-dev-scshca60.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@github-actions
Copy link

github-actions bot commented Feb 23, 2026 •
edited
Loading

Deployed docs-preview for d148f88 to: https://ng-dev-previews-comp--pr-angular-components-32698-docs-yie8752z.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@jermowery jermowery force-pushed the progress-button branch 4 times, most recently from 5d4113c to 55cedae Compare February 23, 2026 19:55
@jermowery
Copy link
Contributor Author

jermowery commented Feb 25, 2026

TGP: https://fusion2.corp.google.com/presubmit/863352307/OCL:863352307:BASE:874578799:1771970895987:f15068c1/targets

@jermowery
Copy link
Contributor Author

jermowery commented Feb 25, 2026

@andrewseguin I have updated the styles so that no one will be broken by this change, which I think is much better for everyone

@jermowery
feat(material/button): Add support for showing a progress indicator i…
d148f88 
…nside the button

Add a new API, testing API, and docs for allowing progress indicators to be projected into a button and have them shown in an accessible manner

Fixes angular#13667
@jermowery
Copy link
Contributor Author

jermowery commented Feb 26, 2026

TGP is green! https://fusion2.corp.google.com/presubmit/863352307/OCL:863352307:BASE:875738620:1772123687304:384906a0/targets

@andrewseguin andrewseguin added the target: minor This PR is targeted for the next minor release label Feb 26, 2026
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Feb 26, 2026
@andrewseguin andrewseguin merged commit b4a89d5 into angular:main Feb 26, 2026
27 of 30 checks passed
@andrewseguin
Copy link
Contributor

andrewseguin commented Feb 26, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@ok7sai ok7sai Awaiting requested review from ok7sai

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/button detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(mat-button): add progress-spinner option

2 participants

@jermowery @andrewseguin