fix(material/sidenav): use sidenav components in autosize example#32820
Open
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Open
fix(material/sidenav): use sidenav components in autosize example#32820yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
The autosize sidenav example incorrectly used mat-drawer and mat-drawer-container instead of mat-sidenav and mat-sidenav-container. Since this example appears in the sidenav documentation under "Resizing an open sidenav", it should use sidenav components. Closes angular#30616
tjshiu
added
the
docs: preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix (documentation example)
What is the current behavior?
The "Autosize sidenav" example (
sidenav-autosize) incorrectly usesmat-drawer-containerandmat-drawercomponents instead ofmat-sidenav-containerandmat-sidenav. This is misleading because the example appears in the sidenav documentation under the "Resizing an open sidenav" section.Closes #30616
What is the new behavior?
The example now correctly uses
mat-sidenav-container,mat-sidenav, andmat-sidenav-content— consistent with other sidenav examples in the documentation. Theautosizeattribute works identically sinceMatSidenavContainerextendsMatDrawerContainer.Additional context
MatSidenavModule, so only the template needed updating.#drawerto#sidenavfor consistency.<div>to<mat-sidenav-content>to match other sidenav examples.