QuantityValue implemented as a fractional number 🐲

[lipchev]

• QuantityValue implemented as a fractional number
• IQuantity interfaces optimized (some methods refactored as extensions)
• QuantityInfo/UnitInfo hierarchy re-implemented (same properties, different constructors)
• QuantityInfoLookup is now public
• UntAbbreviationsCache, UnitParser, QuantityParser optimized
• UnitConverter: re-implemented (multiple versions)
• removed the IConvertible interface
• updated the JsonNet converters
• introducing the SystemTextJson project
• added a new UnitsNetConfiguration project to the Samples, showcasing the new configuration options
• many more tests and benchmarks (perhaps too many)

[lipchev]

@angularsen Clearly, I don't expect this to get merged in the Gitty up! fashion, but at least we have the whole picture, with sources that I can reference.

If you want, send me an e-mail, we could do a quick walk-through / discussion.

[angularsen]

100k lines removed, 100k lines added 🙈

[lipchev]

100k lines removed, 100k lines added 🙈

I tried to create this PR twice before (many months ago), while the changes to the unit definitions were still not merged- and the web interface was giving me an error when trying to browse the files changed.. Something like "Too many files to display" 😄

[angularsen]

Ok, I'm not going to get through a review of this many files anytime soon.
Maybe we should have a screen sharing session and go through it together. I may have some time this weekend, what about you? What timezone are you in?

On the surface though, it seems like this could be split up into chunks. I know it's tedious and extra work, but it will be way faster to review. Do you see any chunks of changes to easily split off into separate PRs?

[lipchev]

Ok, I'm not going to get through a review of this many files anytime soon. Maybe we should have a screen sharing session and go through it together. I may have some time this weekend, what about you? What timezone are you in?

Sofia (GMT+3), but time zones are not relevant to my sleep schedule - so basically any time you want.

On the surface though, it seems like this could be split up into chunks. I know it's tedious and extra work, but it will be way faster to review. Do you see any chunks of changes to easily split off into separate PRs?

Yes, I do have some ideas:

1. UnitAbbreviationsCache and the UnitParser should be more or less free of changes once UnitAbbreviationsCache.CreateEmpty should use the default QuantityInfoLookup #1548 is merged
2. I plan to remove the IConvertible interface tonight (lots of red points there)
3. The QuantityParser has just a few minor changes which I was going to try to push as well (other than that it's mostly just double changing to QuantityValue)
4. QuantityFormatter - there was an issue that I created earlier that should (mostly) solve the differences
5. Refactoring the QuantityInfo can theoretically be done without the ConversionExpressions (which would open the way for the changes to the IQuantity interface and some of the extension methods).
6. The JsonQuantityConverter stuff from SystemText could theoretically come with it's double versions first (but we do need to have a discussion about it)

Hopefully by the time we get to 5) you'd be up to speed (and fed up with PRs) and we can turn back to reviewing / working on the rest of it as a whole 😄

[angularsen]

Ok, sounds good. Just send PRs my way and I'll try to get to them. I have a little bit of extra time this weekend.