Making the ToString paramters optional (IFormattable)
#1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed the `ToString(IFormatProvider?)` overload from the IQuantity interface - removed the `ToString` overloads from the generated quantities (and HowMuch) - replaced the usages of `ToString(IFormatProvider?)` in the tests
|
Hm, I was expecting there to be a very small size difference compared to #1552, but
I don't know what to make of these numbers.. Anyway, I was also a little surprised by the number of breaking changes that this caused in the tests (non-generated).. I initially found the |
angularsen
reviewed
Apr 20, 2025
| @@ -167,15 +167,15 @@ public void LengthTimesSpecificWeightEqualsPressure() | |||
| public void ToStringReturnsCorrectNumberAndUnitWithDefaultUnitWhichIsMeter() | |||
| { | |||
| var meter = Length.FromMeters(5); | |||
| string meterString = meter.ToString(CultureInfo.InvariantCulture); | |||
| string meterString = meter.ToString(null, CultureInfo.InvariantCulture); | |||
There was a problem hiding this comment.
This I don't like, c# users expect certain ToString() signatures to exist and having to use named parameters or pass null is awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToString(IFormatProvider?)overload from theIQuantityinterfaceToStringoverloads from the generated quantities (andHowMuch)ToString(IFormatProvider?)in the testsduplicate of #1552