Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Remove rest_framework from package dependencies #586

@SanketDG

Description

@SanketDG

Description

As part of #565, I was auditing the requirements and found out that DRF was used!

DRF is probably the largest API framework out there for Django, and we don't even have an API!

Diving into the code, it seems like meetups/views.py ApiForVmsView just uses one single class APIView, which just sends out JSON data based on some request params. Nothing some good ol' Django can't do! There's no point of using such a large package to implement something so trivial.

Removing this should be fairly easy.

The second thing to look for how it's used in VMS, and whether we need it at all.

Estimation

12 hours

I'd be interested in mentoring someone formally since this is relatively easy. Please ping me on Zulip if you are relatively new here and you want to get started with your first PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: AvailableIssue was approved and available to claim or abandoned for over 3 days.Type: MaintenanceRepository maintenance.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions