Adds getChildResources method onto PageItems trait to load a resource's child resources - fixes loading availability zone prices and affinity rule members pagination issues

Author: Paul McNally

src/Traits/PageItems.php

@@ -151,27 +151,24 @@ public function updateEntity($entity)
      */
     public function getChildResources($id, $resourceName, $serializer, $filters = [])
     {
-        $page = $this->paginatedRequest($this->collectionPath . '/' . $id . '/' . $resourceName, 1, 15, $filters);
-
-        if ($page->totalItems() == 0) {
-            return [];
-        }
-
-        $page->serializeWith($serializer);
-
-        $items = $page->getItems();
+        $pageNumber = 0;
+        $items = [];
+        do {
+            $pageNumber++;
+            $page = $this->paginatedRequest(
+                $this->collectionPath . '/' . $id . '/' . $resourceName,
+                $pageNumber,
+                15,
+                $filters
+            );
 
-        if ($page->totalPages() == 1) {
-            return $items;
-        }
-        while ($page->pageNumber() < $page->totalPages()) {
-            $page = $this->paginatedRequest($this->collectionPath . '/' . $id . '/' . $resourceName, $page->pageNumber() + 1, 15, $filters);
             $page->serializeWith($serializer);
             $items = array_merge(
                 $items,
                 $page->getItems()
             );
-        }
+        } while ($pageNumber < $page->totalPages());
+
         return $items;
     }
 }