Merge branch 'master' into 50-add-request-id-to-reply-objects

Author: rbibby

.travis.yml

@@ -3,6 +3,7 @@ php:
   - '5.6'
   - '7.1'
   - '7.2'
+  - '7.3'
 
 cache:
  directories:

src/Account/Entities/InvoiceQuery.php

@@ -61,6 +61,11 @@ class InvoiceQuery
      */
     public $status;
 
+    /**
+     * @var \DateTime
+     */
+    public $date;
+
     /**
      * InvoiceQuery constructor.
      *
@@ -76,6 +81,10 @@ public function __construct($item = null)
             ? DateTime::createFromFormat(DateTime::ISO8601, $item->resolution_date)
             : null;
 
+        $date = ($item->date != null)
+            ? DateTime::createFromFormat(DateTime::ISO8601, $item->date)
+            : null;
+
         $this->id = $item->id;
         $this->contactId = $item->contact_id;
         $this->amount = $item->amount;
@@ -86,6 +95,7 @@ public function __construct($item = null)
         $this->contactMethod = $item->contact_method;
         $this->resolution = $item->resolution;
         $this->resolutionDate = $resolutionDate;
+        $this->date = $date;
         $this->status = $item->status;
     }
 }

src/PSS/ReplyClient.php

@@ -94,7 +94,6 @@ public function create($requestId, $reply)
      */
     public function upload($replyId, $name, $content)
     {
-        $name = urlencode($name);
         $uri = "v1/replies/$replyId/attachments/$name";
         $response = $this->request('POST', $uri, $content);
 
@@ -107,7 +106,7 @@ public function upload($replyId, $name, $content)
     /**
      * Downloads an attachment
      *
-     * @return \GuzzleHttp\Psr7\Stream
+     * @return \UKFast\SDK\PSS\Entities\Download
      */
     public function download($replyId, $name)
     {

tests/Account/InvoiceQueryTest.php

@@ -35,7 +35,8 @@ public function get_invoice_query_by_id()
                     "contact_method" => "email",
                     "resolution" => "This issue was resolved.",
                     "resolution_date" => '2019-10-25T00:00:00+01:00',
-                    "status" => "Submitted"
+                    "status" => "Submitted",
+                    "date" => "2019-11-07T10:56:54+00:00"
                 ],
                 "meta" => []
             ])),
@@ -61,6 +62,7 @@ public function get_invoice_query_by_id()
         $this->assertEquals("This issue was resolved.", $invoiceQuery->resolution);
         $this->assertInstanceOf(DateTime::class, $invoiceQuery->resolutionDate);
         $this->assertEquals("Submitted", $invoiceQuery->status);
+        $this->assertInstanceOf(DateTime::class, $invoiceQuery->date);
     }
 
     /**