-
Notifications
You must be signed in to change notification settings - Fork 167
Fixes #462 notice permission denied on authorized_key module #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 17s |
50988a0
to
67345a4
Compare
I think I fixed all the problems related to my code -- I hope I made it 2.7 compatible :) The last failure is
there seems to be a general problem there same for the other freebsd job |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 37s |
67345a4
to
53ad4fb
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 06s |
Also added a changelog fragement |
53ad4fb
to
889ca91
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 38s |
I rebased it on the fixed CI from #640 - I think it's good to merge @saito-hideki |
any chance to get this on the road @saito-hideki ? anything I can do to help the process? |
889ca91
to
3d61341
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 26s |
3d61341
to
6b9fd0a
Compare
An integration test would be nice |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 30s |
6b9fd0a
to
624c151
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 31s |
the tests are run as root it seems, to there is no permission denied happening :) |
SUMMARY
As of right now the authorized_key module does not notice on an "absent" if a authorized_keys file is simply not readable to the executing user. I am trying to fix that
ISSUE TYPE
COMPONENT NAME
authorized_key
ADDITIONAL INFORMATION
Execute as a user that does not have access to the root users authorized keys file
The one without become will succeed before my change and will fail with a permission denied error after my change. The 2nd task will actually remove a key from root user if become privileges are available for the executing user