Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

disk_size and memory_size ignored in molecule.yml #35

@lmelwyn

Description

@lmelwyn

Hi,

At first, thank you for providing this plugin, and secondly, I noticed that "item." is missing a couple of places, so that some definitions in molecule.yml are ignored when creating vms.

grep -ir "default(" | grep -v item
molecule_libvirt/playbooks/create.yml:        {{ disk_size | default(default_disk_size ) }}"
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <memory unit='GiB'>{{ memory_size | default(default_memory_size) }}</memory>
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <currentMemory unit='GiB'>{{ memory_size | default(default_memory_size) }}</currentMemory>
molecule_libvirt/playbooks/templates/vm/vm.xml.j2:  <vcpu placement='static'>{{ vcpu | default(default_vcpu) }}</vcpu>

Also, would you consider adding (or accepting) a couple of miscellaneous start and stop functions corresponding to virsh start and shutdown.

Regards,
Lars Melwyn

Metadata

Metadata

Assignees

Labels

bugThis issue/PR relates to a bug.enhancementThis issue/PR relates to a feature request.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions