Allow user specified ansible-core version (#319)

Author: cidrblock

src/ansible_dev_environment/arg_parser.py

@@ -32,6 +32,7 @@
 
 ENVVAR_MAPPING: dict[str, str] = {
     "ansi": "NO_COLOR",
+    "ansible_core_version": "ADE_ANSIBLE_CORE_VERSION",
     "isolation_mode": "ADE_ISOLATION_MODE",
     "seed": "ADE_SEED",
     "uv": "ADE_UV",
@@ -211,6 +212,14 @@ def parse() -> argparse.Namespace:
         parents=[level2],
         help="Install a collection.",
     )
+
+    install.add_argument(
+        "--acv",
+        "--ansible-core-version",
+        dest="ansible_core_version",
+        help="Ansible core version to use. (e.g. --acv 2.19.0)",
+    )
+
     install.add_argument(
         "-e",
         "--editable",

src/ansible_dev_environment/subcommands/installer.py

@@ -73,10 +73,7 @@ def run(self) -> None:
             err = "Multiple optional dependencies are not supported at this time."
             self._output.critical(err)
 
-        if self._config.args.seed:
-            self._install_dev_tools()
-        else:
-            self._install_core()
+        self._install_ade_deps()
 
         if self._config.args.requirement or self._config.args.cpi:
             self._install_galaxy_requirements()
@@ -114,17 +111,34 @@ def run(self) -> None:
             )
             self._output.note(msg)
 
+    def _install_ade_deps(self) -> None:
+        """Install our dependencies."""
+        core_version = getattr(self._config.args, "ansible_core_version", None)
+
+        if core_version:
+            self._install_core()
+        if self._config.args.seed:
+            self._install_dev_tools()
+        elif core_version is None:
+            self._install_core()
+
     def _install_core(self) -> None:
         """Install ansible-core if not installed already."""
-        msg = "Installing ansible-core."
-        self._output.info(msg)
-
         core = self._config.venv_bindir / "ansible"
         if core.exists():
+            msg = "ansible-core is already installed."
+            self._output.debug(msg)
             return
         msg = "Installing ansible-core."
         self._output.debug(msg)
         command = f"{self._config.venv_pip_install_cmd} ansible-core"
+
+        core_version = getattr(self._config.args, "ansible_core_version", None)
+        if core_version:
+            command += f"=={core_version}"
+            msg = f"Using user specified ansible-core version: {core_version}"
+            self._output.debug(msg)
+
         try:
             subprocess_run(
                 command=command,

tests/integration/test_basic.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import json
+import re
 import sys
 
 from pathlib import Path
@@ -244,3 +245,46 @@ def test_system_site_packages(
     captured = capsys.readouterr()
     assert "with system site packages" in captured.out
     assert "Installed collections include: ansible.utils" in captured.out
+
+
+def test_specified_core_version_pass(
+    tmp_path: Path,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """Install a user-specified core version.
+
+    Args:
+        tmp_path: Temporary directory
+        monkeypatch: Pytest monkeypatch
+    """
+    term_features = TermFeatures(color=False, links=False)
+    output = Output(
+        log_file=f"/{tmp_path}/ansible-dev-environment.log",
+        log_level="INFO",
+        log_append="false",
+        term_features=term_features,
+        verbosity=0,
+    )
+    command = "pip index versions ansible-core"
+    result = subprocess_run(command=command, verbose=True, msg="", output=output)
+
+    version_pattern = re.compile(r"\d+\.\d+\.\d+")
+    versions = version_pattern.findall(result.stdout)
+    second_latest = versions[2]
+
+    venv_path = tmp_path / ".venv"
+
+    monkeypatch.setattr(
+        "sys.argv",
+        [
+            "ade",
+            "install",
+            f"--venv={venv_path}",
+            f"--ansible-core-version={second_latest}",
+        ],
+    )
+    with pytest.raises(SystemExit):
+        main()
+    command = f"{venv_path}/bin/ansible --version"
+    result = subprocess_run(command=command, verbose=True, msg="", output=output)
+    assert second_latest in result.stdout