Skip to content

Commit 1a346e3

Browse files
authored
Make seed option implicit and add --no-seed (#280)
1 parent ce96fdb commit 1a346e3

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/ansible_dev_environment/arg_parser.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,9 @@ def parse() -> argparse.Namespace:
197197
install.add_argument(
198198
# "-adt",
199199
"--seed",
200-
action="store_true",
201-
dest="adt",
200+
action=argparse.BooleanOptionalAction,
201+
default=True,
202+
dest="seed",
202203
help="Install seed packages inside the virtual environment (ansible-dev-tools).",
203204
)
204205

src/ansible_dev_environment/subcommands/installer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def run(self) -> None:
5656
err = "Multiple optional dependencies are not supported at this time."
5757
self._output.critical(err)
5858

59-
if self._config.args.adt:
59+
if self._config.args.seed:
6060
self._install_dev_tools()
6161
else:
6262
self._install_core()

tests/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ def session_venv(session_dir: Path, monkey_session: pytest.MonkeyPatch) -> Confi
195195
[
196196
"ade",
197197
"install",
198+
"--no-seed",
198199
"-r",
199200
str(GALAXY_CACHE / REQS_FILE_NAME),
200201
"--venv",

tests/unit/test_installer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def test_no_adt_install(
271271
args = Namespace(
272272
venv=venv,
273273
verbose=0,
274-
adt=False,
274+
seed=False,
275275
system_site_packages=False,
276276
collection_specifier=None,
277277
requirement=None,
@@ -302,7 +302,7 @@ def test_adt_install(
302302
args = Namespace(
303303
venv=venv,
304304
verbose=0,
305-
adt=True,
305+
seed=True,
306306
system_site_packages=False,
307307
collection_specifier=None,
308308
requirement=None,

0 commit comments

Comments
 (0)