Skip to content

Commit b7ef45f

Browse files
committed
Fix test failure with pyenv or mise pythons
1 parent 19750a0 commit b7ef45f

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

tests/unit/test_treemaker.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
from ansible_dev_environment.output import Output
1919
from ansible_dev_environment.utils import JSONVal
2020

21+
class SafeEnvBuilder(EnvBuilder):
22+
def __init__(self, system_site_packages=False, clear=False,
23+
symlinks=True, upgrade=False, with_pip=False, prompt=None,
24+
upgrade_deps=False):
25+
"""Ensure that symlinks defaults to True because otherwise it will create broken venvs with tools like pyenv, asdf or mise."""
26+
super().__init__(system_site_packages=system_site_packages, clear=clear, symlinks=symlinks, upgrade=upgrade, with_pip=with_pip, prompt=prompt, upgrade_deps=upgrade_deps)
2127

2228
def test_tree_empty(
2329
capsys: pytest.CaptureFixture[str],
@@ -32,7 +38,8 @@ def test_tree_empty(
3238
tmp_path: Pytest fixture.
3339
"""
3440
venv_path = tmp_path / "venv"
35-
EnvBuilder().create(venv_path)
41+
env = SafeEnvBuilder()
42+
env.create(venv_path)
3643

3744
args = Namespace(
3845
venv=venv_path,
@@ -63,7 +70,7 @@ def test_tree_malformed_info(
6370
tmp_path: Pytest fixture.
6471
"""
6572
venv_path = tmp_path / "venv"
66-
EnvBuilder().create(venv_path)
73+
SafeEnvBuilder().create(venv_path)
6774

6875
args = Namespace(
6976
venv=venv_path,
@@ -118,7 +125,7 @@ def test_tree_malformed_deps(
118125
tmp_path: Pytest fixture.
119126
"""
120127
venv_path = tmp_path / "venv"
121-
EnvBuilder().create(venv_path)
128+
SafeEnvBuilder().create(venv_path)
122129

123130
args = Namespace(
124131
venv=venv_path,
@@ -175,7 +182,7 @@ def test_tree_malformed_deps_not_string(
175182
tmp_path: Pytest fixture.
176183
"""
177184
venv_path = tmp_path / "venv"
178-
EnvBuilder().create(venv_path)
185+
SafeEnvBuilder().create(venv_path)
179186

180187
args = Namespace(
181188
venv=venv_path,
@@ -232,7 +239,7 @@ def test_tree_malformed_repo_not_string(
232239
capsys: Pytest stdout capture fixture.
233240
"""
234241
venv_path = tmp_path / "venv"
235-
EnvBuilder().create(venv_path)
242+
SafeEnvBuilder().create(venv_path)
236243

237244
args = Namespace(
238245
venv=venv_path,

0 commit comments

Comments
 (0)