Skip to content

Allow collection install if source is not yet a git repository #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Apr 29, 2024

In the case of a creator created collection, the repo will not have been initialized prior to being installed editable from the extension.

This allows the fall through to take place if the git ls command fails.

Added tests.

The pylint disable list was also updated based on recent releases of ruff.

@cidrblock cidrblock requested a review from ssbarnea as a code owner April 29, 2024 22:20
@cidrblock cidrblock changed the title Fix not a repo Allow collection install if source is not yet a git repository Apr 29, 2024
@cidrblock cidrblock added the bug Something isn't working label Apr 29, 2024
@cidrblock
Copy link
Collaborator Author

Pushing this in to continue some work with the extension. PLMK if there are any concerns.

@cidrblock cidrblock merged commit affe940 into ansible:main Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant