-
Notifications
You must be signed in to change notification settings - Fork 132
fix: reducing space consumption in GitHub runners #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reducing space consumption in GitHub runners #3900
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideTo address GitHub runner space limitations, this PR implements changes across CI scripts and workflows. Log collection scripts (.sh files in "/.ci/") now utilize File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- The duplicated 'Free Disk Space Before Build' step at the job's end might be redundant if the runner environment is ephemeral.
- Consider reducing the verbosity of the 'Show space consumption' step if its detailed output is primarily for initial debugging rather than routine monitoring.
- The PR description mentions 'using moving instead of copying' to reduce disk footprint, but this change doesn't appear in the provided diff.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…tps://github.com/ansys/pymapdl into fix/reducing-space-consumption-in-github-runners
…ocal testing workflow
…es in local and remote scripts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3900 +/- ##
==========================================
- Coverage 88.29% 88.28% -0.02%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13094 13092 -2
- Misses 1736 1738 +2 🚀 New features to boost your workflow:
|
… and remote workflows
…tps://github.com/ansys/pymapdl into fix/reducing-space-consumption-in-github-runners
… local testing workflow
… in local testing workflow
@sourcery-ai review |
@pyansys-ci-bot LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider adding
df -h
logging totest-remote.yml
for consistent space monitoring across workflows. - Consider making log collection failures an error if these artifacts are critical for diagnostics, instead of only echoing a message.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…tps://github.com/ansys/pymapdl into fix/reducing-space-consumption-in-github-runners
Description
Last month we have seen a few errors regarding the runner running out of space.
Hence, let's reduce the disk footprint by removing non used files and using moving instead of copying on the logging steps.
Related link: actions/runner-images#10386
Issue linked
Related to #3751
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Optimize GitHub runner disk space usage by reducing file operations and cleaning up temporary files
Bug Fixes:
CI:
Chores: