Merge pull request #62 from anyproto/GO-3125-shared-spaces-limit

GO-3125 shared spaces limit

Author: cheggaaa

accountlimit/accountlimit.go

@@ -1,3 +1,4 @@
+//go:generate mockgen -destination mock_accountlimit/mock_accountlimit.go github.com/anyproto/any-sync-coordinator/accountlimit AccountLimit
 package accountlimit
 
 import (
@@ -36,6 +37,7 @@ type configGetter interface {
 type SpaceLimits struct {
 	SpaceMembersRead  uint32 `yaml:"spaceMembersRead" bson:"spaceMembersRead"`
 	SpaceMembersWrite uint32 `yaml:"spaceMembersWrite" bson:"spaceMembersWrite"`
+	SharedSpacesLimit uint32 `yaml:"sharedSpacesLimit" bson:"sharedSpacesLimit"`
 }
 
 type Limits struct {
@@ -44,6 +46,7 @@ type Limits struct {
 	FileStorageBytes  uint64    `bson:"fileStorageBytes"`
 	SpaceMembersRead  uint32    `bson:"spaceMembersRead"`
 	SpaceMembersWrite uint32    `bson:"spaceMembersWrite"`
+	SharedSpacesLimit uint32    `bson:"sharedSpacesLimit"`
 	UpdatedTime       time.Time `bson:"updatedTime"`
 }
 
@@ -118,6 +121,7 @@ func (al *accountLimit) GetLimits(ctx context.Context, identity string) (limits
 		Identity:          identity,
 		SpaceMembersRead:  al.defaultLimits.SpaceMembersRead,
 		SpaceMembersWrite: al.defaultLimits.SpaceMembersWrite,
+		SharedSpacesLimit: al.defaultLimits.SharedSpacesLimit,
 		UpdatedTime:       time.Now(),
 	}, nil
 }
@@ -144,5 +148,6 @@ func (al *accountLimit) GetLimitsBySpace(ctx context.Context, spaceId string) (s
 	return SpaceLimits{
 		SpaceMembersRead:  limits.SpaceMembersRead,
 		SpaceMembersWrite: limits.SpaceMembersWrite,
+		SharedSpacesLimit: limits.SharedSpacesLimit,
 	}, nil
 }

accountlimit/accountlimit_test.go

@@ -31,8 +31,11 @@ func TestAccountLimit_SetLimits(t *testing.T) {
 
 	limits := Limits{
 		Identity:          "123",
+		Reason:            "reason",
+		FileStorageBytes:  12345,
 		SpaceMembersRead:  100,
 		SpaceMembersWrite: 200,
+		SharedSpacesLimit: 3,
 	}
 
 	// set
@@ -82,7 +85,7 @@ func TestAccountLimit_GetLimitsBySpace(t *testing.T) {
 
 		limits, err := fx.GetLimitsBySpace(ctx, spaceId)
 		require.NoError(t, err)
-		assert.Equal(t, SpaceLimits{1, 1}, limits)
+		assert.Equal(t, SpaceLimits{1, 1, 0}, limits)
 	})
 
 	t.Run("regular", func(t *testing.T) {
@@ -97,7 +100,7 @@ func TestAccountLimit_GetLimitsBySpace(t *testing.T) {
 
 		limits, err := fx.GetLimitsBySpace(ctx, spaceId)
 		require.NoError(t, err)
-		assert.Equal(t, SpaceLimits{10, 5}, limits)
+		assert.Equal(t, SpaceLimits{10, 5, 3}, limits)
 	})
 
 }
@@ -165,7 +168,8 @@ func (c *testConfig) GetMongo() db.Mongo {
 
 func (c *testConfig) GetAccountLimit() SpaceLimits {
 	return SpaceLimits{
-		SpaceMembersWrite: 5,
 		SpaceMembersRead:  10,
+		SpaceMembersWrite: 5,
+		SharedSpacesLimit: 3,
 	}
 }

accountlimit/mock_accountlimit/mock_accountlimit.go

@@ -12,6 +12,7 @@ import (
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace"
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
+	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/coordinator/coordinatorproto"
@@ -270,6 +271,7 @@ func (c *coordinator) AccountLimitsSet(ctx context.Context, req *coordinatorprot
 		FileStorageBytes:  req.FileStorageLimitBytes,
 		SpaceMembersRead:  req.SpaceMembersRead,
 		SpaceMembersWrite: req.SpaceMembersWrite,
+		SharedSpacesLimit: req.SharedSpacesLimit,
 	})
 }
 
@@ -280,6 +282,16 @@ func (c *coordinator) AclAddRecord(ctx context.Context, spaceId string, payload
 		return
 	}
 
+	statusEntry, err := c.spaceStatus.Status(ctx, spaceId)
+	if err != nil {
+		return
+	}
+
+	if !statusEntry.IsShareable {
+		err = coordinatorproto.ErrSpaceNotShareable
+		return
+	}
+
 	limits, err := c.accountLimit.GetLimitsBySpace(ctx, spaceId)
 	if err != nil {
 		return nil, err
@@ -297,3 +309,73 @@ func (c *coordinator) AclAddRecord(ctx context.Context, spaceId string, payload
 	}
 	return rawRecordWithId, nil
 }
+
+func (c *coordinator) MakeSpaceShareable(ctx context.Context, spaceId string) (err error) {
+	pubKey, err := peer.CtxPubKey(ctx)
+	if err != nil {
+		return coordinatorproto.ErrForbidden
+	}
+	statusEntry, err := c.spaceStatus.Status(ctx, spaceId)
+	if err != nil {
+		return
+	}
+	if statusEntry.Identity != pubKey.Account() {
+		return coordinatorproto.ErrForbidden
+	}
+	if statusEntry.IsShareable {
+		return nil
+	}
+
+	limits, err := c.accountLimit.GetLimitsBySpace(ctx, spaceId)
+	if err != nil {
+		return err
+	}
+	return c.spaceStatus.MakeShareable(ctx, spaceId, limits.SharedSpacesLimit)
+}
+
+func (c *coordinator) MakeSpaceUnshareable(ctx context.Context, spaceId, aclHead string) (err error) {
+	pubKey, err := peer.CtxPubKey(ctx)
+	if err != nil {
+		return coordinatorproto.ErrForbidden
+	}
+	statusEntry, err := c.spaceStatus.Status(ctx, spaceId)
+	if err != nil {
+		return
+	}
+	if statusEntry.Identity != pubKey.Account() {
+		return coordinatorproto.ErrForbidden
+	}
+	if !statusEntry.IsShareable {
+		return nil
+	}
+
+	hasRecord, err := c.acl.HasRecord(ctx, spaceId, aclHead)
+	if err != nil {
+		return err
+	}
+	if !hasRecord {
+		return coordinatorproto.ErrAclHeadIsMissing
+	}
+
+	var (
+		activeMembers int
+		hasInvites    bool
+	)
+	err = c.acl.ReadState(ctx, spaceId, func(s *list.AclState) error {
+		for _, acc := range s.CurrentAccounts() {
+			if acc.Permissions.NoPermissions() {
+				continue
+			}
+			activeMembers++
+		}
+		if len(s.Invites()) > 0 {
+			hasInvites = true
+		}
+		return nil
+	})
+	if hasInvites || activeMembers > 1 {
+		return coordinatorproto.ErrAclNonEmpty
+	}
+
+	return c.spaceStatus.MakeUnshareable(ctx, spaceId)
+}