DROID-4101 Widgets | Enhances filter handling for DataView widgets #2858
+211
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances filter handling for DataView widgets by ensuring proper relation format propagation from StoreOfRelations and improves template resolution logic for object creation in DataView contexts.
- Added a new suspend function
updateFormatForSubscription(StoreOfRelations)to fetch the latest property formats from the store - Updated
buildViewerContextCommonto be suspendable and call the new filter format update function - Refactored object creation logic to use a new dedicated
resolveTemplateForDataViewObjectfunction that prioritizes viewer templates over ObjectType defaults - Added
EXACT_INto the list of permitted conditions for prefilling new objects from filters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DataViewListWidgetContainer.kt | Made buildViewerContextCommon suspend and integrated the new filter format update logic with explanatory comments |
| ObjectSetExtension.kt | Added updateFormatForSubscription overload for StoreOfRelations and new resolveTemplateForDataViewObject function for template resolution |
| HomeScreenViewModel.kt | Refactored proceedWithCreatingDataViewObject to use the new template resolution function and updated named parameters in another call site |
| PermittedConditions.kt | Added EXACT_IN condition to permitted filter conditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
presentation/src/main/java/com/anytypeio/anytype/presentation/sets/ObjectSetExtension.kt
Show resolved
Hide resolved
presentation/src/main/java/com/anytypeio/anytype/presentation/sets/ObjectSetExtension.kt
Show resolved
Hide resolved
konstantiniiv
changed the title
konstantiniiv
deleted the
droid-4101-new-tasks-created-via-the-button-in-the-tasks-widget-dont
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?