Skip to content

[AMORO-3488] Display the file count and file size directly in the table list even when the optimization status is idle #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

smallyao
Copy link
Contributor

@smallyao smallyao commented Mar 27, 2025

Why are the changes needed?

Close #3488.

Brief change log

When the table's optimization status is idle, the file count and file size are shown as zero. To view these details, you need to click on the table name to access the details page. However, it would be more meaningful to display the file count and file size directly in the table list, even when the optimization status is idle.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

Before applying patch
image

After applying patch
image

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…le list even when the optimization status is idle
@github-actions github-actions bot added the module:ams-server Ams server module label Mar 27, 2025
@zhoujinsong
Copy link
Contributor

Hi, thanks for contributing!

The original purpose of displaying file count and file size was to highlight files requiring optimizing. Therefore, idle tables are uniformly displayed as 0. I'm uncertain whether we should alter this representation.

@majin1102 HDYT?

@smallyao
Copy link
Contributor Author

Thank you for your reply. The advantage of this is that it allows us to more intuitively see which tables have a larger number of files and how much space these files occupy. This provides a convenient way to remind us which tables require more attention despite being in an idle state.
@zhoujinsong

@zhoujinsong
Copy link
Contributor

This provides a convenient way to remind us which tables require more attention despite being in an idle state.

The overview page now displays the top 10 size tables, you may get this information from there?

@smallyao
Copy link
Contributor Author

This provides a convenient way to remind us which tables require more attention despite being in an idle state.

The overview page now displays the top 10 size tables, you may get this information from there?
Definitely , this is also a way.

Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 12, 2025
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Display the file count and file size directly in the table list even when the optimization status is idle.
2 participants