feat: consumer credentials pages #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reams-detail-edit
…am-routes-detail-edit
4 tasks
41 tasks
SkyeYoung
commented
May 7, 2025
Comment on lines
+37
to
+39
| useEffect(() => { | ||
| methods.setValue('config', toConfigStr(config)); | ||
| }, [config]); | ||
| }, [config, methods]); |
There was a problem hiding this comment.
follow the suggestions.
Comment on lines
+121
to
+123
| useEffect(() => optionsOb.setPlugins(plugins), [optionsOb, plugins]); | ||
| useEffect(() => optionsOb.setSearch(search), [optionsOb, search]); | ||
| useEffect(() => optionsOb.setMode(mode), [optionsOb, mode]); |
There was a problem hiding this comment.
follow the suggestions in console.
Comment on lines
+69
to
71
| useEffect(() => { | ||
| reinitializeRef.current(); | ||
| }, [deps]); |
There was a problem hiding this comment.
follow the suggestions in console.
bzp2010
approved these changes
May 7, 2025
Comment on lines
+100
to
+119
| <DetailCredentialsTabs /> | ||
| <PageHeader | ||
| title={t('consumers.credentials.edit.title')} | ||
| {...(readOnly && { | ||
| title: t('consumers.credentials.detail.title'), | ||
| extra: ( | ||
| <Button | ||
| onClick={() => setReadOnly(false)} | ||
| size="compact-sm" | ||
| variant="gradient" | ||
| > | ||
| {t('form.btn.edit')} | ||
| </Button> | ||
| ), | ||
| })} | ||
| /> | ||
| <FormTOCBox> | ||
| <CredentialDetailForm readOnly={readOnly} setReadOnly={setReadOnly} /> | ||
| </FormTOCBox> | ||
| </> |
There was a problem hiding this comment.
Is there a button here to return to the credential list?
There was a problem hiding this comment.
Users can directly click on the Credentials tab at the top
Baoyuantop
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
depend on #3016