Skip to content

Conversation

SkyeYoung
Copy link
Member

@SkyeYoung SkyeYoung commented May 7, 2025

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

image image image image

@SkyeYoung SkyeYoung changed the base branch from master to dev/next May 7, 2025 10:56
@SkyeYoung SkyeYoung marked this pull request as ready for review May 7, 2025 10:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new pages and API enhancements for managing plugin configurations. Key changes include the definition of new API types and schemas in the types folder, the addition of new routes and components for list, detail, and add pages, and updates to the routing and navigation configurations to integrate the plugin_configs feature.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/types/schema/apisix/type.ts Added new API response types for plugin configurations.
src/types/schema/apisix/plugin_configs.ts Added plugin_configs schema definitions using zod.
src/types/schema/apisix/index.ts Imported and merged plugin_configs into APISIX exports.
src/routes/plugin_configs/index.tsx Created the list page for plugin configurations.
src/routes/plugin_configs/detail.$id.tsx Developed the detail view with a form for editing configs.
src/routes/plugin_configs/add.tsx Created the add page with form handling and new ID generation.
src/routeTree.gen.ts Integrated plugin_configs routes into the route tree.
src/config/navRoutes.ts Added plugin_configs to the navigation routes.
src/config/constant.ts Defined a constant for the plugin_configs API route.
src/components/form-slice/FormPartPluginConfig.ts Implemented a new form part to consolidate plugin config sections.
src/components/form-slice/FormPartConsumer.ts Updated to use FormSectionPluginsOnly for clarity.
src/apis/plugin_configs.ts Added API client functions for plugin_configs endpoints.
Files not reviewed (1)
  • src/locales/en/common.json: Language not supported

Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably later we could add a prominent hint to inform the user that service should be used in preference to plugin config unless he knows for sure that it is necessary to use it, as a superset it would cover most use cases.

@SkyeYoung
Copy link
Member Author

Probably later we could add a prominent hint to inform the user that service should be used in preference to plugin config unless he knows for sure that it is necessary to use it, as a superset it would cover most use cases.

I think this should be written into the document...

@SkyeYoung SkyeYoung merged commit 6b0e473 into apache:dev/next May 8, 2025
3 of 4 checks passed
@SkyeYoung SkyeYoung deleted the young/feat/plugin-configs branch May 8, 2025 06:11
@bzp2010
Copy link
Contributor

bzp2010 commented May 8, 2025

I've seen too many people who don't read the docs, no one cares what you say in the docs if you don't "get a gun aimed at them".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants