-
Notifications
You must be signed in to change notification settings - Fork 568
feat: plugin_configs pages #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin_configs pages #3020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new pages and API enhancements for managing plugin configurations. Key changes include the definition of new API types and schemas in the types folder, the addition of new routes and components for list, detail, and add pages, and updates to the routing and navigation configurations to integrate the plugin_configs feature.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/types/schema/apisix/type.ts | Added new API response types for plugin configurations. |
src/types/schema/apisix/plugin_configs.ts | Added plugin_configs schema definitions using zod. |
src/types/schema/apisix/index.ts | Imported and merged plugin_configs into APISIX exports. |
src/routes/plugin_configs/index.tsx | Created the list page for plugin configurations. |
src/routes/plugin_configs/detail.$id.tsx | Developed the detail view with a form for editing configs. |
src/routes/plugin_configs/add.tsx | Created the add page with form handling and new ID generation. |
src/routeTree.gen.ts | Integrated plugin_configs routes into the route tree. |
src/config/navRoutes.ts | Added plugin_configs to the navigation routes. |
src/config/constant.ts | Defined a constant for the plugin_configs API route. |
src/components/form-slice/FormPartPluginConfig.ts | Implemented a new form part to consolidate plugin config sections. |
src/components/form-slice/FormPartConsumer.ts | Updated to use FormSectionPluginsOnly for clarity. |
src/apis/plugin_configs.ts | Added API client functions for plugin_configs endpoints. |
Files not reviewed (1)
- src/locales/en/common.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably later we could add a prominent hint to inform the user that service should be used in preference to plugin config unless he knows for sure that it is necessary to use it, as a superset it would cover most use cases.
I think this should be written into the document... |
I've seen too many people who don't read the docs, no one cares what you say in the docs if you don't "get a gun aimed at them". |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?