Skip to content

Conversation

@tiejunhu
Copy link
Contributor

@tiejunhu tiejunhu commented Jul 1, 2025

Align with Application.run and fix the type checker issue on calling arun

also add typing information for SyncTrackingClient.clone method

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz requested a review from elijahbenizzy July 6, 2025 03:44
@tiejunhu tiejunhu closed this Nov 24, 2025
@skrawcz skrawcz reopened this Nov 24, 2025
@skrawcz
Copy link
Contributor

skrawcz commented Nov 24, 2025

@tiejunhu sorry about this -- @elijahbenizzy why did we never merge this?

@elijahbenizzy
Copy link
Contributor

@tiejunhu sorry about this -- @elijahbenizzy why did we never merge this?

@tiejunhu @skrawcz race condition -- this had already been fixed (IIRC I just did this):

) -> Tuple[Action, Optional[dict], State[ApplicationStateType]]:

@elijahbenizzy
Copy link
Contributor

Duplicate 48db829

thanks @tiejunhu !

@tiejunhu
Copy link
Contributor Author

I saw this commit has been included in merged PR. So I closed it. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants