GCInspector should use different thresholds on GC events #4433
+220
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netudima
reviewed
Oct 20, 2025
conf/cassandra.yaml
Outdated
| # Min unit: ms | ||
| # gc_warn_threshold: 1000ms | ||
|
|
||
| # GC Concurrent phase greater than 200 ms will be logged at INFO level |
There was a problem hiding this comment.
the value (200) in the description does not match the value in the commented value lower (1000)
There was a problem hiding this comment.
updated - thanks for catching this!
netudima
reviewed
Oct 20, 2025
| StatusLogger.log(); | ||
| if (isConcurrentPhase(info.getGcCause(), info.getGcName())) | ||
| { | ||
| if (getGcWarnThresholdInMs() != 0 && duration > getGcWarnThresholdInMs()) |
There was a problem hiding this comment.
if it is a concurrent phase = true branch why do we use non-concurrent thresholds here?
There was a problem hiding this comment.
updated - thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cassandra Jira