Update message id to align with its use #11890
Conversation
DaanHoogland
force-pushed
the
missingOfferingUpdateMessage
branch
from
95e0df1 to
d1da772
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
force-pushed
the
missingOfferingUpdateMessage
branch
from
d1da772 to
ef390b2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a message ID mismatch in localization files. The message key for "Changing offering for the volume..." was incorrectly named message.change.offering.processing and has been updated to message.change.offering.for.volume.processing to align with related message keys and its actual usage context.
Key Changes:
- Renamed message ID from
message.change.offering.processingtomessage.change.offering.for.volume.processingin English localization - Reordered Chinese localization entry to maintain consistent line numbering with the English file
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/public/locales/en.json | Updated message key to include .for.volume suffix for consistency with related volume operation messages |
| ui/public/locales/zh_CN.json | Reordered message entry to align with English file structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11890 +/- ##
=========================================
Coverage 16.18% 16.18%
+ Complexity 13306 13305 -1
=========================================
Files 5657 5657
Lines 498464 498464
Branches 60491 60491
=========================================
Hits 80695 80695
- Misses 408787 408788 +1
+ Partials 8982 8981 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "label.edit.traffic.type": "ట్రాఫిక్ రకాన్ని సవరించండి", | ||
| "label.edit.user": "వినియోగదారుని సవరించండి", | ||
| "label.egress": "ఎగ్రెస్", | ||
| "label.egress.rule": "ఎగ్రెస్ పాలన", |
There was a problem hiding this comment.
@DaanHoogland It's great to see the Telugu i18n for the Cloud Stack! I noticed a word where the translations aren't quite the right fit. It appears the system picked synonyms instead of the exact, intended word translations for those terms. Rule supposed to be 'నియమం' not 'పాలన' [ It means Govern ]. "ఎగ్రెస్ నియమం" is correct word :)
There was a problem hiding this comment.
@pavanaravapalli , I only speak west-west-indo-european ;) so please feel free to add a PR to change it. I know of only one person involved in the Telugu translation so far and will ask him (@kiranchavala ) to review it.
There was a problem hiding this comment.
(P.S. happy to play arbiter on your linguistic debates ;)
|
@sureshanaparti was it intended to have te.json in this change? |
@abh1sar , the reason I am including it is because the fix applies to it and will be overlooked otherwise. Happy to take it out and lay the maintenance burden on Telugu maintainers. |
3 participants
Description
This PR fixes a label mismatch
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?