Fix terms, typos and grammar mistakes in the API, error messages, events, etc. #7857

vladimirpetrov · 2023-08-11T14:27:08Z

Description

This PR aligns the use of terminology, renaming VM / virtual machine references to 'Instance' and also capitalising the terms Templates, Network, Snapshot, User, Account in CloudStack APIs, error and log messages, events, tooltips, etc. Many typos, grammar and spelling mistakes were fixed, also terms like IPv4, VPN, VPC, etc. were properly capitalised. Some error messages were cleaned for better readability. The test cases, expecting some exception strings were adjusted accordingly.

Types of changes

Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

None

How Has This Been Tested?

This change has been tested locally using the simulator hypervisor plugin.

…the server

codecov · 2023-08-11T15:22:09Z

Codecov Report

❌ Patch coverage is 15.10791% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (9317a46) to head (e56d148).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/agent/api/storage/OVFHelper.java	0.00%	14 Missing ⚠️
.../cloudstack/api/command/admin/vm/MigrateVMCmd.java	0.00%	9 Missing ⚠️
...k/api/command/user/address/AssociateIPAddrCmd.java	0.00%	5 Missing ⚠️
...mand/user/autoscale/CreateAutoScaleVmGroupCmd.java	0.00%	5 Missing ⚠️
...api/command/admin/systemvm/MigrateSystemVMCmd.java	0.00%	4 Missing ⚠️
...min/network/ReleaseDedicatedGuestVlanRangeCmd.java	0.00%	3 Missing ⚠️
...i/command/admin/vm/ImportUnmanagedInstanceCmd.java	0.00%	3 Missing ⚠️
...command/user/account/DeleteUserFromProjectCmd.java	0.00%	3 Missing ⚠️
...mand/user/autoscale/DeleteAutoScaleVmGroupCmd.java	0.00%	3 Missing ⚠️
...nd/user/autoscale/DeleteAutoScaleVmProfileCmd.java	0.00%	3 Missing ⚠️
... and 48 more

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7857   +/-   ##
=========================================
  Coverage     17.39%   17.39%           
- Complexity    15283    15284    +1     
=========================================
  Files          5888     5888           
  Lines        526130   526130           
  Branches      64232    64232           
=========================================
  Hits          91542    91542           
  Misses       424255   424255           
  Partials      10333    10333

Flag	Coverage Δ
uitests	`3.62% <ø> (ø)`
unittests	`18.44% <15.10%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2023-08-16T17:00:40Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2025-06-05T10:11:19Z

hi @vladimirpetrov please fix the conflicts in the PR branch.

sudo87 · 2025-08-01T14:37:30Z

@blueorangutan package

blueorangutan · 2025-08-01T14:38:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-01T15:46:09Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14511

sudo87 · 2025-08-01T18:04:51Z

@blueorangutan package

blueorangutan · 2025-08-01T18:06:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-01T19:47:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14512

sudo87 · 2025-08-04T04:09:28Z

@blueorangutan test

blueorangutan · 2025-08-04T04:10:03Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-10T16:00:04Z

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

github-actions · 2025-09-11T11:08:26Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-09-11T11:41:32Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-09-11T13:06:28Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

blueorangutan · 2025-09-11T13:58:39Z

[SF] Trillian test result (tid-14280)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 75938 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7857-t14280-kvm-ol8.zip
Smoke tests completed. 138 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestMigrateVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
test_06_download_detached_volume	`Error`	314.98	test_volumes.py
ContextSuite context=TestVolumes>:teardown	`Error`	125.11	test_volumes.py
test_04_deploy_vnf_appliance	`Error`	311.76	test_vnf_templates.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	`Error`	1516.47	test_hostha_kvm.py

github-actions · 2025-09-11T16:03:27Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sudo87 · 2025-09-15T14:06:29Z

@blueorangutan package

blueorangutan · 2025-09-15T14:08:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-15T17:19:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15022

harikrishna-patnala · 2025-09-16T04:20:25Z

@blueorangutan test

blueorangutan · 2025-09-16T04:22:03Z

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-16T20:38:16Z

[SF] Trillian test result (tid-14351)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55156 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7857-t14351-kvm-ol8.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.19	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	39.20	test_kubernetes_clusters.py

github-actions · 2025-09-17T09:42:04Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sudo87 · 2025-10-30T05:29:52Z

api/src/main/java/com/cloud/vm/snapshot/VMSnapshot.java

    enum State {
-        Allocated("The VM snapshot is allocated but has not been created yet."), Creating("The VM snapshot is being created."), Ready(
-                "The VM snapshot is ready to be used."), Reverting("The VM snapshot is being used to revert"), Expunging("The volume is being expunging"), Removed(
+        Allocated("The Instance Snapshot is allocated but has not been created yet."), Creating("The Instance snapshot is being created."), Ready(


need to check functional impact.

Aligning use of terminology, fix typos and other grammar mistakes in …

babc9a2

…the server

boring-cyborg bot added component:agent component:api component:ipv6 labels Aug 11, 2023

github-actions bot added the status:has-conflicts label Aug 16, 2023

DaanHoogland added this to the 4.20.0.0 milestone Sep 29, 2023

JoaoJandre modified the milestones: 4.20.0.0, 4.21.0.0 Sep 10, 2024

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

sudo87 added 2 commits August 1, 2025 19:57

resolve merge conflict with main

c26b755

resolve conflict with main

ea90f0c

github-actions bot removed the status:has-conflicts label Aug 1, 2025

fix build

61d7d96

sudo87 added 2 commits August 1, 2025 21:22

Merge branch 'main' into polish_server

6b44ef3

fix unit test

027552d

sudo87 self-assigned this Aug 1, 2025

sureshanaparti requested review from DaanHoogland and abh1sar August 4, 2025 05:56

github-actions bot added the status:has-conflicts label Sep 11, 2025

github-actions bot added status:has-conflicts and removed status:has-conflicts labels Sep 11, 2025

github-actions bot removed the status:has-conflicts label Sep 11, 2025

handle review comment and merge main

c1d05b8

sudo87 force-pushed the polish_server branch from cf5fb79 to c1d05b8 Compare September 11, 2025 13:06

github-actions bot added the status:has-conflicts label Sep 11, 2025

merge main

c71bbb6

github-actions bot removed the status:has-conflicts label Sep 11, 2025

github-actions bot added the status:has-conflicts label Sep 11, 2025

resolve conflict

e56d148

github-actions bot removed the status:has-conflicts label Sep 15, 2025

harikrishna-patnala modified the milestones: 4.22.0, 4.23 Sep 17, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Sep 17, 2025

github-actions bot added the status:has-conflicts label Sep 17, 2025

sudo87 reviewed Oct 30, 2025

View reviewed changes

Fix terms, typos and grammar mistakes in the API, error messages, events, etc. #7857

Are you sure you want to change the base?

Fix terms, typos and grammar mistakes in the API, error messages, events, etc. #7857

Uh oh!

Conversation

vladimirpetrov commented Aug 11, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov bot commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 16, 2023

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

sudo87 commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

sudo87 commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

sudo87 commented Aug 4, 2025

Uh oh!

blueorangutan commented Aug 4, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

sudo87 commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

harikrishna-patnala commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

sudo87 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Aug 11, 2023 •

edited

Loading