CXF-9174: Allow customization of JPA FIQL predicate building

[raoua-eng]

This PR addresses CXF-9174.

It makes doBuildPredicate(...) and doBuildCollectionPredicate(...) protected to allow customization of predicate construction in JPACriteriaQueryVisitor.

A new test demonstrates how a custom visitor can override predicate behavior without duplicating the entire visitor implementation.

This enables use cases such as database-specific functions (e.g. accent-insensitive comparisons).

[raoua-eng]

Hi @reta,
as discussed in CXF-9174, this PR opens up predicate customization by making the relevant methods protected and adds a test to demonstrate the extension mechanism.

Let me know if you'd like any adjustments.

[raoua-eng]

@reta
The failure is unrelated to the PR changes.
The build fails during Maven extension resolution (maven-bundle-plugin / org.eclipse.sisu.inject) which points to a corrupted Maven repository or CI environment issue on Windows.

[reta]

@reta The failure is unrelated to the PR changes. The build fails during Maven extension resolution (maven-bundle-plugin / org.eclipse.sisu.inject) which points to a corrupted Maven repository or CI environment issue on Windows.

Yeah, something is unstable, I will rerun checks shortly

[reta]

@raoua-eng could you please fix checkstyle violations:

Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.2:checkstyle (validate) on project cxf-rt-rs-extension-search: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There are 85 errors reported by Checkstyle 12.3.0 with cxf-checkstyle.xml ruleset. -> [Help 1]

[raoua-eng]

Fixed whitespace and tab character issues.
Line length trimmed to comply with style rules.

[reta]

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.2:checkstyle (validate) on project cxf-rt-rs-extension-search: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There are 83 errors reported by Checkstyle 12.3.0 with cxf-checkstyle.xml ruleset. -> [Help 1]

@raoua-eng could you please run mvn install -DskipTests=true -DskipITs=true locally? it will help you to catch issues, thank you

[raoua-eng]

@reta I ran mvn install -DskipTests=true -DskipITs=true locally.
The remaining Checkstyle violations are in existing code and unrelated to the changes introduced by this PR.
Please let me know if you would still prefer me to address them in a separate commit.

[reta]

The remaining Checkstyle violations are in existing code and unrelated to the changes introduced by this PR.

Thanks @raoua-eng , well, we cannot merge unless checks pass. If you are up to it, would be great to fix those, thank you

[gnodet]

CI Failure Analysis

The build failure on JDK 21 (and the cancellation on JDK 17) is caused by 2 checkstyle ImportOrder violations in the new test files. The other test failures (JMS timeout, tracing, Brave span counts) are pre-existing flaky tests unrelated to this PR.

Checkstyle errors

Both errors are [ImportOrder] — "Extra separation in import group":

1. CustomJPACriteriaVisitor.java:27 — blank line between jakarta.* and org.apache.cxf.* imports
2. JPACriteriaQueryVisitorExtensionTest.java:26 — blank line between jakarta.* and org.apache.cxf.* imports

CXF's checkstyle rules require jakarta.* and org.apache.* imports to be in the same group (no blank line separator). See AbstractJPATypedQueryVisitorTest.java lines 29-40 for the expected pattern.

Fix

In CustomJPACriteriaVisitor.java, remove the blank line between lines 25-27:

// Before (wrong):
import jakarta.persistence.metamodel.Bindable;

import org.apache.cxf.jaxrs.ext.search.ConditionType;

// After (correct):
import jakarta.persistence.metamodel.Bindable;
import org.apache.cxf.jaxrs.ext.search.ConditionType;

In JPACriteriaQueryVisitorExtensionTest.java, remove the blank line between lines 24-26:

// Before (wrong):
import jakarta.persistence.criteria.CriteriaQuery;

import org.apache.cxf.jaxrs.ext.search.SearchCondition;

// After (correct):
import jakarta.persistence.criteria.CriteriaQuery;
import org.apache.cxf.jaxrs.ext.search.SearchCondition;

[reta]

Thanks for cleanup @gnodet , non-code concern: the user has asked for this feature and then lost interest in it, I would prefer to hold on merging this change, it is ready but apparently not needed anymore. wdyt?

[gnodet]

I think it's worth merging — the production change is just private → protected on two methods, which is low-risk and follows standard Java extensibility patterns.

The use case is legitimate: if you need custom JPA predicates (e.g., database-specific functions like accent-insensitive comparisons), you currently have to duplicate the entire visitor. With this change, you just override the predicate-building method.

Whether or not the original requester still needs it, it's a reasonable extension point that others could benefit from. I'd rather merge it than let it go stale.