Allow extension of JPA criteria query predicate building#2941
Closed
gnodet wants to merge 1 commit intoapache:mainfrom
Closed
Allow extension of JPA criteria query predicate building#2941gnodet wants to merge 1 commit intoapache:mainfrom
gnodet wants to merge 1 commit intoapache:mainfrom
Conversation
Make doBuildPredicate and doBuildCollectionPredicate methods protected in AbstractJPATypedQueryVisitor to allow subclasses to customize predicate construction for specific properties or collection checks. Add getEntityManager() accessor to AbstractJPATypedQueryVisitorTest and new test classes demonstrating the extension capability. Based on PR apache#2798 by mkarg, with fixes for checkstyle compliance (tabs to spaces, import ordering) and corrected test assertions.
Contributor
Author
|
Superseded — pushed fixes directly to #2798 instead (merge from main + checkstyle/test fixes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doBuildPredicateanddoBuildCollectionPredicatemethodsprotectedinAbstractJPATypedQueryVisitorto allow subclasses to customize predicate constructiongetEntityManager()accessor toAbstractJPATypedQueryVisitorTestfor use in test subclassesCustomJPACriteriaVisitorandJPACriteriaQueryVisitorExtensionTestdemonstrating the extension capabilityThis is based on #2798 by @mkarg, with the following improvements:
path.getModel()instead ofpath.getAlias()(which returns null) for attribute identificationcount(authors)syntax that actually triggers the collection check pathCloses #2798