SGA-11419 Added snowflake ability for if not exists after create view… #1961
+102
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, also added ability to write view name before if not exists in snowflake as it is implemented, replaced dialect of with trait functions
iffyio
reviewed
Jul 21, 2025
| Box::new(BigQueryDialect {}), | ||
| ]); | ||
| let _ = dialects.verified_stmt(sql); | ||
| let sql = "CREATE VIEW v IF NOT EXISTS AS SELECT 1"; |
There was a problem hiding this comment.
From a quick look I couldn't find which dialects in practice support this syntax? Do you have a link to documentation for one such dialect?
related the MR not super sure it would be necessary to have this behavior covered by a flag and the parser can always look to accept CREATE VIEW IF NOT EXISTS v, as well as the other syntax if its relevant)
There was a problem hiding this comment.
You're right, I couldn't find official documentation for this syntax, though we have confirmed it works in practice on Snowflake.
I'm happy to remove the dialect flag and update the parser to support both forms for all dialects. Let me know if you'd like me to proceed with that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, also added ability to write view name before if not exists in snowflake as it is implemented, replaced dialect of with trait functions