-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TEST: enable pushdown_filters and reorder_filters by default #18873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 |
|
🤖: Benchmark completed Details
|
|
I am also testing with just I am going to focus my efforts on profiling these queries which seem to have gotten the most slower: Here is the query: set datafusion.execution.parquet.binary_as_string = true
SELECT "SearchPhrase" FROM hits WHERE "SearchPhrase" <> '' ORDER BY "SearchPhrase" LIMIT 10;Basically my next steps are to profile these queries and see what is slower (and if it is related to filter representation, I will go focus on apache/arrow-rs#8902) |
Looks like we are very close! FYI, there a couple more slow than query 24: |
( I am using this PR to test, I don't intend to merge it yet )
Which issue does this PR close?
filter_pushdown) by default #3463Rationale for this change
We have made non trivial progress in filter representation in Parquet. Let's see where performance is now.
What changes are included in this PR?
arrow,parquet57.1.0 #18820pushdown_filtersandreorder_filtersAre these changes tested?
By CI tests
Are there any user-facing changes?