Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 21, 2025

( I am using this PR to test, I don't intend to merge it yet )

Which issue does this PR close?

Rationale for this change

We have made non trivial progress in filter representation in Parquet. Let's see where performance is now.

What changes are included in this PR?

Are these changes tested?

By CI tests

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate proto Related to proto crate datasource Changes to the datasource crate labels Nov 21, 2025
@alamb
Copy link
Contributor Author

alamb commented Nov 21, 2025

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing almab/pushdown_no_reorder (5f981c3) to d65fb86 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb
Copy link
Contributor Author

alamb commented Nov 21, 2025

🤖: Benchmark completed

Details

Comparing HEAD and almab_pushdown_no_reorder
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ almab_pushdown_no_reorder ┃         Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2551.79 ms │                2641.80 ms │      no change │
│ QQuery 1     │  1243.61 ms │                1229.67 ms │      no change │
│ QQuery 2     │  2346.81 ms │                2311.35 ms │      no change │
│ QQuery 3     │  1167.32 ms │                1191.10 ms │      no change │
│ QQuery 4     │  2294.62 ms │                2288.95 ms │      no change │
│ QQuery 5     │ 27985.03 ms │               27656.39 ms │      no change │
│ QQuery 6     │  4053.85 ms │                 226.26 ms │ +17.92x faster │
│ QQuery 7     │  3494.19 ms │                3513.39 ms │      no change │
└──────────────┴─────────────┴───────────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                        ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                        │ 45137.21ms │
│ Total Time (almab_pushdown_no_reorder)   │ 41058.90ms │
│ Average Time (HEAD)                      │  5642.15ms │
│ Average Time (almab_pushdown_no_reorder) │  5132.36ms │
│ Queries Faster                           │          1 │
│ Queries Slower                           │          0 │
│ Queries with No Change                   │          7 │
│ Queries with Failure                     │          0 │
└──────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ almab_pushdown_no_reorder ┃         Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.50 ms │                   2.25 ms │  +1.11x faster │
│ QQuery 1     │    49.67 ms │                  49.68 ms │      no change │
│ QQuery 2     │   133.62 ms │                 140.38 ms │   1.05x slower │
│ QQuery 3     │   166.70 ms │                 162.10 ms │      no change │
│ QQuery 4     │  1090.56 ms │                1198.10 ms │   1.10x slower │
│ QQuery 5     │  1461.59 ms │                1548.31 ms │   1.06x slower │
│ QQuery 6     │     2.12 ms │                   2.13 ms │      no change │
│ QQuery 7     │    54.55 ms │                  66.47 ms │   1.22x slower │
│ QQuery 8     │  1433.65 ms │                1488.60 ms │      no change │
│ QQuery 9     │  1844.72 ms │                1931.06 ms │      no change │
│ QQuery 10    │   369.28 ms │                 491.66 ms │   1.33x slower │
│ QQuery 11    │   425.74 ms │                 551.28 ms │   1.29x slower │
│ QQuery 12    │  1318.48 ms │                1603.68 ms │   1.22x slower │
│ QQuery 13    │  2109.54 ms │                2331.21 ms │   1.11x slower │
│ QQuery 14    │  1259.09 ms │                1494.43 ms │   1.19x slower │
│ QQuery 15    │  1245.60 ms │                1307.52 ms │      no change │
│ QQuery 16    │  2620.69 ms │                2726.07 ms │      no change │
│ QQuery 17    │  2609.73 ms │                2728.07 ms │      no change │
│ QQuery 18    │  5100.37 ms │                5002.86 ms │      no change │
│ QQuery 19    │   130.79 ms │                 142.85 ms │   1.09x slower │
│ QQuery 20    │  2028.58 ms │                1871.08 ms │  +1.08x faster │
│ QQuery 21    │  2312.59 ms │                2328.77 ms │      no change │
│ QQuery 22    │  3915.08 ms │                3870.71 ms │      no change │
│ QQuery 23    │ 15959.92 ms │                1319.59 ms │ +12.09x faster │
│ QQuery 24    │   216.67 ms │                 305.42 ms │   1.41x slower │
│ QQuery 25    │   489.18 ms │                 643.89 ms │   1.32x slower │
│ QQuery 26    │   228.37 ms │                 327.35 ms │   1.43x slower │
│ QQuery 27    │  2886.80 ms │                3008.12 ms │      no change │
│ QQuery 28    │ 23490.32 ms │               23740.19 ms │      no change │
│ QQuery 29    │  1002.61 ms │                 966.82 ms │      no change │
│ QQuery 30    │  1344.43 ms │                1405.91 ms │      no change │
│ QQuery 31    │  1400.41 ms │                1371.60 ms │      no change │
│ QQuery 32    │  4790.37 ms │                4556.49 ms │      no change │
│ QQuery 33    │  5923.70 ms │                5556.62 ms │  +1.07x faster │
│ QQuery 34    │  5945.11 ms │                6014.82 ms │      no change │
│ QQuery 35    │  1951.68 ms │                1902.09 ms │      no change │
│ QQuery 36    │   120.31 ms │                  20.14 ms │  +5.97x faster │
│ QQuery 37    │    52.29 ms │                  19.77 ms │  +2.65x faster │
│ QQuery 38    │   120.18 ms │                  19.84 ms │  +6.06x faster │
│ QQuery 39    │   195.96 ms │                  20.03 ms │  +9.79x faster │
│ QQuery 40    │    43.41 ms │                  21.49 ms │  +2.02x faster │
│ QQuery 41    │    41.28 ms │                  19.84 ms │  +2.08x faster │
│ QQuery 42    │    33.50 ms │                  19.76 ms │  +1.70x faster │
└──────────────┴─────────────┴───────────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                        ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                        │ 97921.71ms │
│ Total Time (almab_pushdown_no_reorder)   │ 84299.02ms │
│ Average Time (HEAD)                      │  2277.25ms │
│ Average Time (almab_pushdown_no_reorder) │  1960.44ms │
│ Queries Faster                           │         11 │
│ Queries Slower                           │         13 │
│ Queries with No Change                   │         19 │
│ Queries with Failure                     │          0 │
└──────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ almab_pushdown_no_reorder ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 130.60 ms │                 140.94 ms │  1.08x slower │
│ QQuery 2     │  27.21 ms │                  29.14 ms │  1.07x slower │
│ QQuery 3     │  38.54 ms │                  37.73 ms │     no change │
│ QQuery 4     │  29.51 ms │                  29.50 ms │     no change │
│ QQuery 5     │  87.56 ms │                  87.26 ms │     no change │
│ QQuery 6     │  19.58 ms │                  19.41 ms │     no change │
│ QQuery 7     │ 222.77 ms │                 217.85 ms │     no change │
│ QQuery 8     │  35.64 ms │                  31.97 ms │ +1.11x faster │
│ QQuery 9     │ 102.85 ms │                 101.82 ms │     no change │
│ QQuery 10    │  62.98 ms │                  64.30 ms │     no change │
│ QQuery 11    │  18.53 ms │                  18.70 ms │     no change │
│ QQuery 12    │  50.76 ms │                  52.28 ms │     no change │
│ QQuery 13    │  46.88 ms │                  47.60 ms │     no change │
│ QQuery 14    │  13.46 ms │                  14.05 ms │     no change │
│ QQuery 15    │  24.40 ms │                  24.33 ms │     no change │
│ QQuery 16    │  25.36 ms │                  25.05 ms │     no change │
│ QQuery 17    │ 150.32 ms │                 151.15 ms │     no change │
│ QQuery 18    │ 279.19 ms │                 275.19 ms │     no change │
│ QQuery 19    │  38.11 ms │                  37.98 ms │     no change │
│ QQuery 20    │  48.93 ms │                  50.65 ms │     no change │
│ QQuery 21    │ 332.26 ms │                 309.93 ms │ +1.07x faster │
│ QQuery 22    │  18.70 ms │                  17.68 ms │ +1.06x faster │
└──────────────┴───────────┴───────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                        ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                        │ 1804.14ms │
│ Total Time (almab_pushdown_no_reorder)   │ 1784.51ms │
│ Average Time (HEAD)                      │   82.01ms │
│ Average Time (almab_pushdown_no_reorder) │   81.11ms │
│ Queries Faster                           │         3 │
│ Queries Slower                           │         2 │
│ Queries with No Change                   │        17 │
│ Queries with Failure                     │         0 │
└──────────────────────────────────────────┴───────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate documentation Improvements or additions to documentation optimizer Optimizer rules proto Related to proto crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable parquet filter pushdown (filter_pushdown) by default

1 participant