Skip to content

[Improvement][service] Use depList instead of preTasks in TaskNode, to avoid type conversion #17169

@unigof

Description

@unigof

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

There are two kinds of attribute to keep pre node info in TaskNode:

private String preTasks;
private List<Long> depList;

And they are be assigned at the same time:

    public void setPreTasks(String preTasks) {
        this.preTasks = preTasks;
        this.depList = JSONUtils.toList(preTasks, Long.class);
    }

So, we can use depList to replace preTasks when iterater pre task node.
e.g graphHasCycle method in WorkflowDefinitionServiceImpl

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions