Skip to content

[3.3] Fix code formatting issues on pull request #15391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented May 17, 2025

What is the purpose of the change?

for discussion of #15388.
Pre Condition: add stefanzweifel/git-auto-commit-action@* to github actions permission.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@zrlw zrlw force-pushed the 3.3-feature-fixCodeFormatOnPullReq branch 2 times, most recently from ab2a687 to 26bc5c3 Compare May 17, 2025 05:26
@zrlw zrlw force-pushed the 3.3-feature-fixCodeFormatOnPullReq branch from 26bc5c3 to 0353e3e Compare May 17, 2025 06:42
Comment on lines +39 to +41
permissions:
# Give the default GITHUB_TOKEN write permission to commit the changed files back to the repository.
contents: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All repos under apache organization cannot grant write permission to workflows running on PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the write permission is ganted for the PR branch of the forked repos such as https://github.com/zrlw/dubbo, it should not be trigged on apache/dubbo because the code formatting issues should be fixed at forked repos, do you mean the forked repos is also under apache organization?
by the way, this PR is posted only for for discussion of #15388. We still need to discuss whether it's necessary to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controlling permissions for GITHUB_TOKEN
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token
contents: write allows the action to create a release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, there are many contributors who don't enable github actions on their forked repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the write permission is ganted for the PR branch of the forked repos such as https://github.com/zrlw/dubbo, it should not be trigged on apache/dubbo because the code formatting issues should be fixed at forked repos, do you mean the forked repos is also under apache organization? by the way, this PR is posted only for for discussion of #15388. We still need to discuss whether it's necessary to do this.

Question about it.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrlw zrlw closed this Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants