FINERACT-2477: Refactor SavingsAccountTransactionsApiResource command…

[SamaSVM]

Description

Refactored the SavingsAccountTransactionsApiResource logic.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

@SamaSVM check the error in the Backward compatibility logs

[Aman-Mittal]

I think for refractor it will be a better approach to create separate helper functions so that it will maintain separation of concern and make these code more modular

[SamaSVM]

That’s a good point. However, I implemented the task according to its current description and requirements. I’m not sure what future changes are planned for the project or how they might be affected by my implementation.

[Aman-Mittal]

Hi, @SamaSVM It is the ticket created based on this PR https://github.com/apache/fineract/pull/5465/changes by @Saifulhuq01,
As his feature is not currently merge yet it will cause direct conflict. Maybe you should wait a bit for this?

@Saifulhuq01 I have linked your tickets as dependent state.

[Saifulhuq01]

Hi, @SamaSVM It is the ticket created based on this PR https://github.com/apache/fineract/pull/5465/changes by @Saifulhuq01, As his feature is not currently merge yet it will cause direct conflict. Maybe you should wait a bit for this?

@Saifulhuq01 I have linked your tickets as dependent state.

@Aman-Mittal Thanks for linking the tickets. @SamaSVM My force debit logic is fixed and awaiting final review from the maintainers on #5465. I will let you know the second it merges so you can proceed with your refactor.