-
Notifications
You must be signed in to change notification settings - Fork 183
[FLINK-37834] Flink JDBC support ClickHouse Dialect #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@eskabetxe could you please start CI or review PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I can't start CI/CD sorry. @1996fanrui can you start it?
I review the main code and left minor comments.
I dont review the tests as you have a TODO to some refactoring there.
You also need to add this module on flink-connector-jdbc-architecture.
.idea/vcs.xml
Outdated
@@ -1,24 +1,24 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<project version="4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes in this file should be reverted
<packaging>jar</packaging> | ||
|
||
<properties> | ||
<clickhouse.version>0.6.2</clickhouse.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the last version available 0.8.6?
@eskabetxe
|
Is it okay if I refactor some of the core classes in the tests, like making them protected? |
Its ok to bump some versions and is ok also change some test methods from private to protected if you need to override them.. |
… archunit, 3. Driver version for tests = 0.6.2 (ClickHouse testcontainers support that version) 4. Refactored UPDATE statement
Ive refactored tests but cannot use click house driver version 0.7+ since click house testcontainers support 0.6.2. |
🔌 ClickHouse Dialect for Flink Link JDBC Connector
This project provides a ClickHouse SQL dialect implementation for the Apache Flink JDBC Connector.
🚀 Purpose
Apache Flink’s Link JDBC connector offers a flexible way to integrate with relational databases through dialects. However, native support for ClickHouse’s SQL features (e.g. merge trees, upserts, batch writes) is limited in SQL CLI.
✨ Features
✅ Custom ClickHouseDialect integration
✅ Column quoting and identifier case sensitivity fixes
✅ Insert/update query support tailored for ClickHouse (pkFields removed from update statement)
TODO:
Refactor Tests: Some methods are private (like getStreamFields() that's why I had to recreate some test classes)
Jira Issue:
https://issues.apache.org/jira/projects/FLINK/issues/FLINK-37834