[FLINK-37652][Connectors/Opensearch] Move to Flink to 2.0.0 #50
Conversation
reta
force-pushed
the
FLINK-37652
branch
3 times, most recently
from
d23b2de to
5e7f21a
Compare
|
@snuyanzin whenever you have time to look, please |
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Thanks a lot, @snuyanzin ! Addressed all except |
| { | ||
| flink: 1.20, | ||
| jdk: '8, 11, 17, 21', | ||
| branch: main | ||
| }, { | ||
| flink: 1.19.0, | ||
| flink: 1.19.2, | ||
| jdk: '8, 11, 17, 21', | ||
| branch: v1.2 | ||
| }, { |
There was a problem hiding this comment.
sorry, I think I missed it:
since 1.18-SNAPSHOT was removed in this PR
how about replacing 1.18.2 (which is a couple of lines below) with 1.20.1 ?
There was a problem hiding this comment.
We already run against 1.20 (https://github.com/apache/flink-connector-opensearch/pull/50/files#diff-b077dee47bccc37c2b6fef32cdd102f36acadad73ede1f410c3941f39c50cd94R38), do you mean replacing 1.20 with 1.20.1?
There was a problem hiding this comment.
Updated to 1.20.1 and added 1.20-SNAPSHOT as well
|
thank you for addressing feedback 👍 , |
Signed-off-by: Andriy Redko <drreta@gmail.com>
[FLINK-37652][Connectors/Opensearch] Move to Flink to 2.0.0