Skip to content

[FLINK-37709][metrics] add file descriptor jvm metrics #26492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-37709][metrics] add file descriptor jvm metrics #26492

wants to merge 1 commit into from

Conversation

HuangZhenQiu
Copy link
Contributor

What is the purpose of the change

Add file descriptor related JVM metrics

Brief change log

  • Add the default registration in MetricUtils
  • Added test in MetricUtilsTest

Verifying this change

This change added tests and can be verified as follows:

  • Added test in MetricUtilsTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 21, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-37709-file-descriptor-metrics branch from 6fae8ca to a21e6f5 Compare April 22, 2025 00:29
mxm
mxm approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxm mxm mxm approved these changes

@davidradl davidradl davidradl approved these changes

@RocMarshal RocMarshal RocMarshal approved these changes

Assignees
No one assigned
Labels
component=Runtime/Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HuangZhenQiu @flinkbot @mxm @davidradl @RocMarshal