Skip to content

[FLINK-37711] Remove unused getJobGraph from PipelineExecutorUtils #26493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

beliefer
Copy link
Contributor

@beliefer beliefer commented Apr 22, 2025

What is the purpose of the change

This PR aims to remove unused getJobGraph from PipelineExecutorUtils.
The method getJobGraph in PipelineExecutorUtils is only used in test cases.
The client uses StreamGraph now. We should update these test cases.

Brief change log

Remove unused getJobGraph from PipelineExecutorUtils.

Verifying this change

This change is already covered by existing tests, such as (DefaultPackagedProgramRetrieverITCase).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@beliefer
Copy link
Contributor Author

@flinkbot run azure

@davidradl
Copy link
Contributor

@beliefer could you go into a bit more detail in the jira as to why the Jobgraph is not used. I see it is used in a few places and is not deprecated.

@beliefer
Copy link
Contributor Author

@beliefer could you go into a bit more detail in the jira as to why the Jobgraph is not used. I see it is used in a few places and is not deprecated.

Yes. Jobgraph is still used. I mean the method PipelineExecutorUtils.getJobGraph is not used anymore except some tests.

@beliefer
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants