Skip to content

[FLINK-37728][python] add support org.apache.flink.table.runtime.operators.window.GlobalWindow #26506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

suez1224
Copy link
Contributor

@suez1224 suez1224 commented Apr 25, 2025

What is the purpose of the change

add support for org.apache.flink.table.runtime.operators.window.GlobalWindow. In flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/embedded/EmbeddedPythonWindowOperator.java, org.apache.flink.table.runtime.operators.window.Window is used, but we only have implementation for org.apache.flink.streaming.api.windowing.windows.GlobalWindow, which can't be cast to org.apache.flink.table.runtime.operators.window.Window.

Brief change log

  • add implementation for org.apache.flink.table.runtime.operators.window.GlobalWindow
  • modify pyflink to use org.apache.flink.table.runtime.operators.window.GlobalWindow instead of org.apache.flink.streaming.api.windowing.windows.GlobalWindow.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (o)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 25, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@suez1224 suez1224 force-pushed the FLINK-37728 branch 3 times, most recently from 2b8d700 to aea32b5 Compare April 28, 2025 06:25
@suez1224 suez1224 changed the title [FLINK-37728][python] fix incorrect import org.apache.flink.table.runtime.operators.window.Window [FLINK-37728][python] add support org.apache.flink.table.runtime.operators.window.GlobalWindow Apr 29, 2025
Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuangXingBo HuangXingBo merged commit 8bd248e into apache:master Apr 29, 2025
HuangXingBo pushed a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants