Skip to content

HIVE-29582: Exclude test jars from lib directory (Naveen Gangam)#6455

Merged
dengzhhu653 merged 2 commits intoapache:masterfrom
nrg4878:HIVE-29582
May 6, 2026
Merged

HIVE-29582: Exclude test jars from lib directory (Naveen Gangam)#6455
dengzhhu653 merged 2 commits intoapache:masterfrom
nrg4878:HIVE-29582

Conversation

@nrg4878
Copy link
Copy Markdown
Contributor

@nrg4878 nrg4878 commented Apr 27, 2026

What changes were proposed in this pull request?

POM changes to exclude test jars from the lib directory.

Why are the changes needed?

Cleaner practices and smaller distributions

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually

Copy link
Copy Markdown
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldnt quite figure out where in the dependency tree this was getting pulled in from but generally is a good idea to exclude all tests.jar files from the lib.

This llap-common-tests that you see in the lib is most probably because of missing <scope>tests<scope> here

hive/llap-server/pom.xml

Lines 330 to 335 in ee6848d

<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-llap-common</artifactId>
<version>${project.version}</version>
<classifier>tests</classifier>
</dependency>

By default it is taking compile scope and getting packaged. Would be good to correct there as well

dependency-tree.rtf

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@dengzhhu653 dengzhhu653 merged commit 1a80cc5 into apache:master May 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants