perf: Improve metadata record merging and compaction with lazy deserialization#14103
Draft
yihua wants to merge 8 commits intoapache:masterfrom
Draft
perf: Improve metadata record merging and compaction with lazy deserialization#14103yihua wants to merge 8 commits intoapache:masterfrom
yihua wants to merge 8 commits intoapache:masterfrom
Conversation
yihua
force-pushed
the
perf-mdt-record-lazy-deserialization
branch
from
dd4ba58 to
ab45fdb
Compare
| import static org.apache.hudi.common.util.StringUtils.fromUTF8Bytes; | ||
| import static org.apache.hudi.metadata.HoodieMetadataPayload.KEY_FIELD_NAME; | ||
|
|
||
| public class SerializableMetadataIndexedRecord implements GenericRecord, KryoSerializable, Serializable { |
Contributor
There was a problem hiding this comment.
Instead of introducing another class, can we just update the existing metadata record so we have less code to migrate?
Contributor
Author
There was a problem hiding this comment.
I'm still exploring the right approach. I think if we'd like to avoid the Avro deserialization and keep the byte array read from the HFile until the deserialization is necessary, we still need a separate data structure besides the existing metadata record or payload class.
yihua
force-pushed
the
perf-mdt-record-lazy-deserialization
branch
from
967b2f9 to
b6192e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Fixes #14370
Summary and Changelog
Impact
Risk Level
Documentation Update
Contributor's checklist