feat: avro support applying field-ids based on name mapping #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterRaindrop
changed the title
wgtmac
reviewed
Jun 24, 2025
mapleFU
reviewed
Jun 24, 2025
wgtmac
suggested changes
Jun 30, 2025
MisterRaindrop
force-pushed
the
rain/support_field_ids_mapping_2
branch
from
46391f0 to
7ddeb06
Compare
|
@wgtmac hi please help me review it again when you’re free. |
wgtmac
suggested changes
Jul 8, 2025
wgtmac
suggested changes
Jul 14, 2025
|
@wgtmac hi, I update code and all test is ok |
MisterRaindrop
force-pushed
the
rain/support_field_ids_mapping_2
branch
from
13aef21 to
a19781e
Compare
wgtmac
reviewed
Jul 21, 2025
|
Thanks a lot for reviewing my changes , I’ve updated the code based on your suggestions, please check if there are any other suggestions for this PR? @wgtmac |
wgtmac
reviewed
Jul 22, 2025
| const auto& original_attrs = original_node->customAttributesAt(i); | ||
| const auto& existing_attrs = original_attrs.attributes(); | ||
| for (const auto& attr_pair : existing_attrs) { | ||
| attributes.addAttribute(attr_pair.first, attr_pair.second, false); |
wgtmac
reviewed
Jul 22, 2025
MisterRaindrop
force-pushed
the
rain/support_field_ids_mapping_2
branch
from
9ad7bcf to
c5a71ad
Compare
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
MisterRaindrop
force-pushed
the
rain/support_field_ids_mapping_2
branch
from
c5a71ad to
94cee21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #128