feat(connector): Add Iceberg sink connector #2191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetz
reviewed
Sep 23, 2025
| RestCatalog::new(catalog_config) | ||
| } | ||
|
|
||
| //#[inline(always)] |
There was a problem hiding this comment.
What was a reason to have this commented out? I think it'd best to either add the appropriate comment or remove this code to avoid any confusion.
There was a problem hiding this comment.
This was the original code for having support for hms catalogs but later I commented it out because it's correct afaik but the current build for the iceberg-hms catalog is broken, so I didn't really knew what to do with it. I'll remove it and add it later on when they fix it if that sounds good.
spetz
reviewed
Sep 23, 2025
| messages: Vec<ConsumedMessage>, | ||
| ) -> Result<(), Error> { | ||
| info!( | ||
| "Iceberg sink with ID: {} received: {} messages, format: {}", |
There was a problem hiding this comment.
Maybe let's change both of these info logs, to the debug level.
hubcio
reviewed
Sep 23, 2025
hubcio
reviewed
Sep 23, 2025
spetz
reviewed
Sep 23, 2025
| address = "localhost:8090" | ||
| username = "iggy" | ||
| password = "iggy" | ||
| # token = "secret" # Personal Access Token (PAT) can be used instead of username and password |
There was a problem hiding this comment.
Keep this as token = "" (not commented out)
|
Also, fix CI :) |
EdgarModesto23
changed the title
EdgarModesto23
changed the title
EdgarModesto23
force-pushed
the
iceberg-connector
branch
from
76e4323 to
9bcb236
Compare
EdgarModesto23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1850
This PR adds and Iceberg sink connector with the following features:
I originally intended to include support for hms catalogs, but i had issues compiling the current implementation of the hms iceberg catalog in rust
It is also worth mentioning that although i included the code necessary to support glue, the iceberg glue catalog team is still working towards appending data files