[Bug][API] PATCH /blueprints/:id cannot update skipCollectors and fullSync fields

[owais-maswala]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

PATCH requests to /api/blueprints/:id cannot update skipCollectors or fullSync fields. The values remain unchanged in the database regardless of what's sent in the request body.

Other SyncPolicy fields like skipOnFail update correctly.

What do you expect to happen

skipCollectors and fullSync should be updateable via PATCH like other blueprint fields.

How to reproduce

// Check current value
curl -s <devlake_url>/api/blueprints/<bp_id> | jq '{skipCollectors, fullSync}'
// {"skipCollectors": true, "fullSync": false}

// Attempt to update
curl -X PATCH <devlake_url>/api/blueprints/<bp_id>
-H "Content-Type: application/json"
-d '{"skipCollectors": false, "fullSync": true}'

// Check again - values unchanged
curl -s <devlake_url>/api/blueprints/<bp_id> | jq '{skipCollectors, fullSync}'
// {"skipCollectors": true, "fullSync": false}

Anything else

No response

Version

v1.0.3-beta9

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[dosubot]

This happens because skipCollectors and fullSync are defined in an embedded struct (TriggerSyncPolicy) within Blueprint, but the code doesn't use the mapstructure:"squash" tag. As a result, PATCH requests only update these fields if you nest them under triggerSyncPolicy in your JSON payload, like this:

{
  "triggerSyncPolicy": {
    "skipCollectors": false,
    "fullSync": true
  }
}

Sending skipCollectors and fullSync at the top level won't work due to how the backend decodes the request body. Other fields like skipOnFail work because they're not nested.

To fix this in the code, add mapstructure:"squash" to the TriggerSyncPolicy struct. That way, skipCollectors and fullSync can be updated at the top level, just like skipOnFail. There are currently no docs, issues, or PRs that mention this bug or a workaround. The persistence logic is fine—it's just the decoding step that causes the problem.

References:
Blueprint model and struct embedding
PATCH handler and decoding logic

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[github-actions]

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

[github-actions]

This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.