Skip to content

Conversation

@sanyakapoor27
Copy link

Reason for this PR

As described in #688, this PR is done to remove the maven warnings due to version property which may break future maven builds.

What changes are included in this PR?

Removed the version property from child modules where it can be inherited from the parent and replaced expressions with constants in .

Are these changes tested?

yes, verified maven build after the changes.

Are there any user-facing changes?

no

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (ba30326) to head (719f7a0).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #689       +/-   ##
===========================================
+ Coverage   59.94%   95.11%   +35.16%     
===========================================
  Files          65        8       -57     
  Lines        9213      737     -8476     
  Branches      975        0      -975     
===========================================
- Hits         5523      701     -4822     
+ Misses       3690       36     -3654     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yecol
Copy link
Contributor

yecol commented May 27, 2025

Hi @sanyakapoor27, thanks for your commit!

However, I suggest not adding version constants in all child POMs, as this could make maintenance more difficult. It’s better to remove the version tags from child POMs.

Copy link
Contributor

@yecol yecol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@sanyakapoor27
Copy link
Author

Hi @yecol, thanks for the review!
I had added the constants to remove the "'version' contains an expression but should be a constant." warning. It looks like that warning might still pop up when expressions are used in child poms, but I definitely understand your concerns about maintenance. I'll make the suggested changes! :)

@yecol
Copy link
Contributor

yecol commented May 28, 2025

Thanks for the prompt update!
However, according to the build log in CI, it seems there’s still a version variable in the root POM of the maven-projects.
I believe you’ll also need to change the version in line 32 to the hardcoded value 0.12.0-SNAPSHOT.

@Thespica
Copy link
Contributor

Hi @sanyakapoor27 , Ubuntu 20.04 LTS runner has been removed on 2025-04-15(link). I will contribute a PR to fix the error. You can rebase the main branch after the updating of GitHub Action Runner : )

@sanyakapoor27
Copy link
Author

sanyakapoor27 commented May 28, 2025

@yecol thanks for the review once again! I had previously updated line 32 of the root POM to 0.12.0-SNAPSHOT, but that led to "[FATAL] Non-resolvable parent POM" errors when building the child modules.

This error and the warning mentioned in the issue #688 were gone when the < version> in the child poms also referred to 0.12.0-SNAPSHOT. This can be viewed here: Stack Overflow. In such a case, please let me know what would be the best course of action?

@yangxk1
Copy link
Contributor

yangxk1 commented Jul 2, 2025

@sanyakapoor27 Hi! The Spark CI has been fixed, could you please rerun the CI workflow?

@yangxk1
Copy link
Contributor

yangxk1 commented Sep 9, 2025

@sanyakapoor27, do you have time to continue to complete this pr? That has not been updated for too long will be closed

@sanyakapoor27
Copy link
Author

Hi! @yangxk1 i apologise for not getting back to you sooner due to some unforseen commitments, i will update it by this weekend. thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants