Remove default image as public constants (#172)

Author: radtriste

controllers/builder/openshiftbuilder_test.go

@@ -65,7 +65,7 @@ func Test_openshiftBuilderManager_Reconcile(t *testing.T) {
 	assert.NoError(t, client.Get(context.TODO(), namespacedName, bc))
 	is := &imgv1.ImageStream{}
 	assert.NoError(t, client.Get(context.TODO(), namespacedName, is))
-	assert.Contains(t, *bc.Spec.Source.Dockerfile, "FROM "+workflowdef.GetDefaultImageTag(workflowdef.DefaultWorkflowBuilderImage)+" AS builder")
+	assert.Contains(t, *bc.Spec.Source.Dockerfile, "FROM "+workflowdef.GetDefaultWorkflowBuilderImageTag()+" AS builder")
 
 	// Reconcile
 	// unfortunately, the fake buildclient doesn't implement the RESTAPI, thus we can't push a new build to it

controllers/workflowdef/image.go

@@ -23,8 +23,8 @@ import (
 const (
 	latestImageTag              = "latest"
 	nightlySuffix               = "nightly"
-	DefaultWorkflowDevModeImage = "quay.io/kiegroup/kogito-swf-devmode"
-	DefaultWorkflowBuilderImage = "quay.io/kiegroup/kogito-swf-builder"
+	defaultWorkflowDevModeImage = "quay.io/kiegroup/kogito-swf-devmode"
+	defaultWorkflowBuilderImage = "quay.io/kiegroup/kogito-swf-builder"
 )
 
 // GetWorkflowAppImageNameTag retrieve the tag for the image based on the Workflow based annotation, <workflowid>:latest otherwise
@@ -37,11 +37,11 @@ func GetWorkflowAppImageNameTag(w *v1alpha08.SonataFlow) string {
 }
 
 func GetDefaultWorkflowDevModeImageTag() string {
-	return GetDefaultImageTag(DefaultWorkflowDevModeImage)
+	return GetDefaultImageTag(defaultWorkflowDevModeImage)
 }
 
 func GetDefaultWorkflowBuilderImageTag() string {
-	return GetDefaultImageTag(DefaultWorkflowBuilderImage)
+	return GetDefaultImageTag(defaultWorkflowBuilderImage)
 }
 
 func GetDefaultImageTag(imgTag string) string {