refactor:remove repeated build beforeImage and afterImage in undo/bui… #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
好的 |
…lder package Signed-off-by: LeeHao <1838249551@qq.com>
…utor into BaseExecutor Signed-off-by: LeeHao <1838249551@qq.com>
Signed-off-by: LeeHao <1838249551@qq.com>
lxfeng1997
reviewed
May 29, 2025
lxfeng1997
reviewed
Jun 13, 2025
| @@ -81,3 +80,57 @@ func (e *ATExecutor) ExecWithValue(ctx context.Context, execCtx *types.ExecConte | |||
| execCtx.NamedValues = util.ValueToNamedValue(execCtx.Values) | |||
| return e.ExecWithNamedValue(ctx, execCtx, f) | |||
| } | |||
|
|
|||
| func (e *ATExecutor) NewInsertExecutor(parserCtx *types.ParseContext, execContext *types.ExecContext, hooks []exec.SQLHook) internal.Executor { | |||
There was a problem hiding this comment.
修改成实现数据库接口，由各自的数据库接口去实现不同的sqltype，不在at_executor中那么多判断，保证后续的接入新数据库时的拓展性。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
refactor the architecture of build beforeImage and afterImage.
But now its support MySQL only, other DBMS are left to support other tasks.
Which issue(s) this PR fixes:
Fixes #751