Fix active xa rollback failure and added error message judgment #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
=========================================
Coverage ? 38.03%
=========================================
Files ? 186
Lines ? 11243
Branches ? 0
=========================================
Hits ? 4276
Misses ? 6542
Partials ? 425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
bug
Code-Fight
reviewed
Aug 18, 2025
pkg/datasource/sql/conn_xa.go
Outdated
|
|
||
| errMsg := err.Error() | ||
| // Check for XAER_RMFAIL error with "already ended" message | ||
| if strings.Contains(errMsg, "XAER_RMFAIL") && strings.Contains(errMsg, "already ended") { |
There was a problem hiding this comment.
The string matching approach in isXAER_RMFAILAlreadyEnded() is fragile
Consider using error codes or types instead of string matching
Different database vendors might format error messages differently
There was a problem hiding this comment.
Okay, I'm trying to reproduce him and add constant Err code judgment.
|
If we can improve the unit test coverage, that would be even better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
with ：#672 Fix active xa rollback failure and added error message judgment
Which issue(s) this PR fixes:
Fixes #
#708
Special notes for your reviewer:
Does this PR introduce a user-facing change?: