[MSOURCES-141] Check duplication of attached jar should be configurable to not fail when using the build cache

[jira-importer]

Olivier Lamy opened MSOURCES-141 and commented

because MSOURCES-121 using source jar mojo and build cache generate an error as the cache restore a project with attached artifacts and so the source mojo fail because of this.

Caused by: org.apache.maven.plugin.MojoExecutionException: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them.
    at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources (AbstractSourceJarMojo.java:309)
    at org.apache.maven.plugins.source.AbstractSourceJarMojo.packageSources (AbstractSourceJarMojo.java:257)
    at org.apache.maven.plugins.source.AbstractSourceJarMojo.execute (AbstractSourceJarMojo.java:225)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject (BuildCacheMojosExecutionStrategy.java:224)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute (BuildCacheMojosExecutionStrategy.java:131)

---

Affects: 3.3.0

Attachments:

• issue-msources-141.zip (2.00 kB)

Issue Links:

• MSOURCES-121 Check for duplicated addition of the same file
  ("is caused by")
• MSOURCES-140 Build fails when using install deploy

1 votes, 4 watchers

[jira-importer]

Hans Aikema commented

Ran into this issue as well, and in my view. I'm not knowingly using any build cache, but run into this issue when putting to sequential lifecycle phases on a CLI invocation (e.g. mvn verify sonar:sonar deploy in the practical build pipeline usage to ensure that all binaries are available to run SonarQube before deploying a new snapshot.

It's reproducible with a slightly modified version of the simple archetype (only adding the source plugin and configuring its jar-no-fork execution (see attached).

Working:

• mvn package
• mvn verify

Breaking:

• mvn package verify

 

[jira-importer]

Cheng Pan commented

it also breaks creating a shaded source jar