Improve error message for unresolved expressions#11615
Conversation
Signed-off-by: 高春晖 <18220699480@163.com>
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) { |
There was a problem hiding this comment.
could be extracted as dedicated branch/concern to provide cohesion over coupling.
| for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) { | |
| return enhanceDependencies(...) |
There was a problem hiding this comment.
I have no idea what that comment means
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java
Show resolved
Hide resolved
Adjust if statement formatting to comply with project code style: - Split OR conditions onto separate lines with proper indentation - Ensures consistency with Spotless formatting rules
GaoSSR
force-pushed
the
fix/improve-error-message-issue-10324
branch
from
5867ad5 to
1bafff2
Compare
|
Thanks for the reviews! Ready to merge? |
|
The CI failure on macOS + Java 25 is a network timeout issue when downloading I've pushed an empty commit to trigger a re-run. Should pass once the network is stable. |
Signed-off-by: 高春晖 <18220699480@163.com>
|
I prefer keeping the current implementation - if-else is more readable than ternary operators for this case. But if the project has a standard style guide, I'm happy to adjust. Could a maintainer make the final call? @elharo |
|
@elharo Please assign appropriate label to PR according to the type of change. |
3 participants
Fixes #10324