feat: added missing fields on TopicStats#1136
Open
jffp113 wants to merge 1 commit intoapache:masterfrom
Open
Conversation
RobertIndie
reviewed
Nov 23, 2023
Member
RobertIndie
left a comment
There was a problem hiding this comment.
Could you add a test to verify that it could get these stats correctly?
Contributor
|
I think we need to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
When using the admin api with golang there is some missing fields on topic stats:
https://pulsar.apache.org/docs/next/admin-api-topics/#get-stats
Modifications
Added missing fields on topic stats
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation