Skip to content

Support parsing Doris SHOW RESOURCES syntax#38598

Open
ccxxxyy wants to merge 1 commit into
apache:masterfrom
ccxxxyy:issueNo
Open

Support parsing Doris SHOW RESOURCES syntax#38598
ccxxxyy wants to merge 1 commit into
apache:masterfrom
ccxxxyy:issueNo

Conversation

@ccxxxyy
Copy link
Copy Markdown
Contributor

@ccxxxyy ccxxxyy commented Apr 8, 2026

for #31458

official document:

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@ccxxxyy
Copy link
Copy Markdown
Contributor Author

ccxxxyy commented Apr 8, 2026

  • Regarding RESOURCES and RESOURCETYPE, Doris does not treat them as reserved keywords. Therefore, I have added them to identifierKeywordsUnambiguous in BaseRule.g4, so that they can be used in places where identifiers are expected.

  • Added two assertions and test cases (SELECT resources FROM t_resources and SELECT resourcetype FROM t_resourcetype) in src/main/resources/case/dml/select.xml and src/main/resources/sql/supported/dml/select.xml as counterexamples. All assertion tests passed, verifying that RESOURCES and RESOURCETYPE can be successfully used as identifiers.

  • All modifications made in DALStatement.g4, DorisKeyword.g4, and BaseRule.g4 have been marked with // DORIS ADDED BEGIN and // DORIS ADDED END to facilitate future maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant